aboutsummaryrefslogtreecommitdiff
path: root/src/main/java/org/traccar
diff options
context:
space:
mode:
authorAnton Tananaev <anton@traccar.org>2022-07-12 11:06:22 -0700
committerAnton Tananaev <anton@traccar.org>2022-07-12 11:06:22 -0700
commit3f46f759c24746ddd2b8cd05cfc6cb99d5f7fd48 (patch)
treedf5d4afa522f2287a60e351ebf7be972b86b65f9 /src/main/java/org/traccar
parent7ccffa266e87badbbcfde73db86216fd4c667f35 (diff)
downloadtrackermap-server-3f46f759c24746ddd2b8cd05cfc6cb99d5f7fd48.tar.gz
trackermap-server-3f46f759c24746ddd2b8cd05cfc6cb99d5f7fd48.tar.bz2
trackermap-server-3f46f759c24746ddd2b8cd05cfc6cb99d5f7fd48.zip
Filter notifications by device access (fix #4888)
Diffstat (limited to 'src/main/java/org/traccar')
-rw-r--r--src/main/java/org/traccar/database/NotificationManager.java2
-rw-r--r--src/main/java/org/traccar/session/cache/CacheManager.java8
2 files changed, 7 insertions, 3 deletions
diff --git a/src/main/java/org/traccar/database/NotificationManager.java b/src/main/java/org/traccar/database/NotificationManager.java
index ecb44b1d4..5be627f2a 100644
--- a/src/main/java/org/traccar/database/NotificationManager.java
+++ b/src/main/java/org/traccar/database/NotificationManager.java
@@ -98,7 +98,7 @@ public class NotificationManager {
}
notifications.forEach(notification -> {
- cacheManager.getNotificationUsers(notification.getId()).forEach(user -> {
+ cacheManager.getNotificationUsers(notification.getId(), event.getDeviceId()).forEach(user -> {
for (String notificator : notification.getNotificatorsTypes()) {
try {
notificatorManager.getNotificator(notificator).send(user, event, position);
diff --git a/src/main/java/org/traccar/session/cache/CacheManager.java b/src/main/java/org/traccar/session/cache/CacheManager.java
index cd71f5f9f..c1697faf9 100644
--- a/src/main/java/org/traccar/session/cache/CacheManager.java
+++ b/src/main/java/org/traccar/session/cache/CacheManager.java
@@ -123,10 +123,14 @@ public class CacheManager implements BroadcastInterface {
}
}
- public List<User> getNotificationUsers(long notificationId) {
+ public List<User> getNotificationUsers(long notificationId, long deviceId) {
try {
lock.readLock().lock();
- return notificationUsers.get(notificationId);
+ var users = deviceLinks.get(deviceId).get(User.class).stream()
+ .collect(Collectors.toUnmodifiableSet());
+ return notificationUsers.get(notificationId).stream()
+ .filter(user -> users.contains(user.getId()))
+ .collect(Collectors.toUnmodifiableList());
} finally {
lock.readLock().unlock();
}