aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAllan Wang <me@allanwang.ca>2019-04-13 19:00:40 -0400
committerGitHub <noreply@github.com>2019-04-13 19:00:40 -0400
commitb70bdd67219502dc16d4c9ec387afdbc8f124d33 (patch)
treefafba2e6a2a74a4e1eb1adaae1704a0042a6df85
parentc39b86013320642f8e346a4554e183d5e78c9975 (diff)
downloadfrost-b70bdd67219502dc16d4c9ec387afdbc8f124d33.tar.gz
frost-b70bdd67219502dc16d4c9ec387afdbc8f124d33.tar.bz2
frost-b70bdd67219502dc16d4c9ec387afdbc8f124d33.zip
Video settings (#1390)
* Add autoplay setting option * Update changelog
-rw-r--r--app/src/main/kotlin/com/pitchedapps/frost/settings/Behaviour.kt9
-rw-r--r--app/src/main/res/values/strings_pref_behaviour.xml2
-rw-r--r--app/src/main/res/xml/frost_changelog.xml5
3 files changed, 15 insertions, 1 deletions
diff --git a/app/src/main/kotlin/com/pitchedapps/frost/settings/Behaviour.kt b/app/src/main/kotlin/com/pitchedapps/frost/settings/Behaviour.kt
index 10fa5c99..b77c0f2d 100644
--- a/app/src/main/kotlin/com/pitchedapps/frost/settings/Behaviour.kt
+++ b/app/src/main/kotlin/com/pitchedapps/frost/settings/Behaviour.kt
@@ -19,8 +19,10 @@ package com.pitchedapps.frost.settings
import ca.allanwang.kau.kpref.activity.KPrefAdapterBuilder
import com.pitchedapps.frost.R
import com.pitchedapps.frost.activities.SettingsActivity
+import com.pitchedapps.frost.facebook.FB_URL_BASE
import com.pitchedapps.frost.utils.Prefs
import com.pitchedapps.frost.utils.REQUEST_REFRESH
+import com.pitchedapps.frost.utils.launchWebOverlay
/**
* Created by Allan Wang on 2017-06-30.
@@ -58,6 +60,13 @@ fun SettingsActivity.getBehaviourPrefs(): KPrefAdapterBuilder.() -> Unit = {
descRes = R.string.enable_pip_desc
}
+ plainText(R.string.autoplay_settings) {
+ descRes = R.string.autoplay_settings_desc
+ onClick = {
+ launchWebOverlay("${FB_URL_BASE}settings/videos/")
+ }
+ }
+
checkbox(R.string.exit_confirmation, Prefs::exitConfirmation, { Prefs.exitConfirmation = it }) {
descRes = R.string.exit_confirmation_desc
}
diff --git a/app/src/main/res/values/strings_pref_behaviour.xml b/app/src/main/res/values/strings_pref_behaviour.xml
index 62e94112..77c35c1c 100644
--- a/app/src/main/res/values/strings_pref_behaviour.xml
+++ b/app/src/main/res/values/strings_pref_behaviour.xml
@@ -17,6 +17,8 @@
<string name="force_message_bottom_desc">When loading a message thread, trigger a scroll to the bottom of the page rather than loading the page as is.</string>
<string name="enable_pip">Enable PIP</string>
<string name="enable_pip_desc">Enable picture in picture videos</string>
+ <string name="autoplay_settings">Autoplay Settings</string>
+ <string name="autoplay_settings_desc">Open Facebook\'s auto play settings. Note that it must be disabled for PIP to work.</string>
<string name="exit_confirmation">Exit Confirmation</string>
<string name="exit_confirmation_desc">Show confirmation dialog before exiting the app</string>
<string name="analytics">Analytics</string>
diff --git a/app/src/main/res/xml/frost_changelog.xml b/app/src/main/res/xml/frost_changelog.xml
index c9b8477e..1895e46f 100644
--- a/app/src/main/res/xml/frost_changelog.xml
+++ b/app/src/main/res/xml/frost_changelog.xml
@@ -8,7 +8,9 @@
<version title="v2.2.4" />
<item text="Show top bar to allow sharing posts" />
- <item text="" />
+ <item text="Fix unmuting videos when autoplay is enabled" />
+ <item text="Add shortcut to toggle autoplay in settings > behaviour" />
+ <item text="Update theme" />
<item text="" />
<version title="v2.2.3" />
@@ -17,6 +19,7 @@
<item text="Apply notification keyword filter to title as well" />
<item text="Remove round icon settings as they are the default in Facebook" />
<item text="Update theme" />
+ <item text="Update translations" />
<version title="v2.2.2" />
<item text="New marketplace shortcut" />