From b70bdd67219502dc16d4c9ec387afdbc8f124d33 Mon Sep 17 00:00:00 2001 From: Allan Wang Date: Sat, 13 Apr 2019 19:00:40 -0400 Subject: Video settings (#1390) * Add autoplay setting option * Update changelog --- app/src/main/kotlin/com/pitchedapps/frost/settings/Behaviour.kt | 9 +++++++++ app/src/main/res/values/strings_pref_behaviour.xml | 2 ++ app/src/main/res/xml/frost_changelog.xml | 5 ++++- 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/app/src/main/kotlin/com/pitchedapps/frost/settings/Behaviour.kt b/app/src/main/kotlin/com/pitchedapps/frost/settings/Behaviour.kt index 10fa5c99..b77c0f2d 100644 --- a/app/src/main/kotlin/com/pitchedapps/frost/settings/Behaviour.kt +++ b/app/src/main/kotlin/com/pitchedapps/frost/settings/Behaviour.kt @@ -19,8 +19,10 @@ package com.pitchedapps.frost.settings import ca.allanwang.kau.kpref.activity.KPrefAdapterBuilder import com.pitchedapps.frost.R import com.pitchedapps.frost.activities.SettingsActivity +import com.pitchedapps.frost.facebook.FB_URL_BASE import com.pitchedapps.frost.utils.Prefs import com.pitchedapps.frost.utils.REQUEST_REFRESH +import com.pitchedapps.frost.utils.launchWebOverlay /** * Created by Allan Wang on 2017-06-30. @@ -58,6 +60,13 @@ fun SettingsActivity.getBehaviourPrefs(): KPrefAdapterBuilder.() -> Unit = { descRes = R.string.enable_pip_desc } + plainText(R.string.autoplay_settings) { + descRes = R.string.autoplay_settings_desc + onClick = { + launchWebOverlay("${FB_URL_BASE}settings/videos/") + } + } + checkbox(R.string.exit_confirmation, Prefs::exitConfirmation, { Prefs.exitConfirmation = it }) { descRes = R.string.exit_confirmation_desc } diff --git a/app/src/main/res/values/strings_pref_behaviour.xml b/app/src/main/res/values/strings_pref_behaviour.xml index 62e94112..77c35c1c 100644 --- a/app/src/main/res/values/strings_pref_behaviour.xml +++ b/app/src/main/res/values/strings_pref_behaviour.xml @@ -17,6 +17,8 @@ When loading a message thread, trigger a scroll to the bottom of the page rather than loading the page as is. Enable PIP Enable picture in picture videos + Autoplay Settings + Open Facebook\'s auto play settings. Note that it must be disabled for PIP to work. Exit Confirmation Show confirmation dialog before exiting the app Analytics diff --git a/app/src/main/res/xml/frost_changelog.xml b/app/src/main/res/xml/frost_changelog.xml index c9b8477e..1895e46f 100644 --- a/app/src/main/res/xml/frost_changelog.xml +++ b/app/src/main/res/xml/frost_changelog.xml @@ -8,7 +8,9 @@ - + + + @@ -17,6 +19,7 @@ + -- cgit v1.2.3