aboutsummaryrefslogtreecommitdiff
path: root/androidApp/src/main/java/mx/trackermap/TrackerMap/android/details/commands
diff options
context:
space:
mode:
authorIván Ávalos <avalos@disroot.org>2022-01-17 02:48:40 -0600
committerIván Ávalos <avalos@disroot.org>2022-01-17 02:48:40 -0600
commitcafc0a05c3997ecaa9683ebf119a247e9a139356 (patch)
tree50fc5a632fd69d725cfccf512a58d113694415d3 /androidApp/src/main/java/mx/trackermap/TrackerMap/android/details/commands
parente38960ff845bddbd463c43801ad01834f77474f2 (diff)
downloadetbsa-trackermap-mobile-cafc0a05c3997ecaa9683ebf119a247e9a139356.tar.gz
etbsa-trackermap-mobile-cafc0a05c3997ecaa9683ebf119a247e9a139356.tar.bz2
etbsa-trackermap-mobile-cafc0a05c3997ecaa9683ebf119a247e9a139356.zip
Improved observer management
Diffstat (limited to 'androidApp/src/main/java/mx/trackermap/TrackerMap/android/details/commands')
-rw-r--r--androidApp/src/main/java/mx/trackermap/TrackerMap/android/details/commands/UnitCommandsFragment.kt17
1 files changed, 16 insertions, 1 deletions
diff --git a/androidApp/src/main/java/mx/trackermap/TrackerMap/android/details/commands/UnitCommandsFragment.kt b/androidApp/src/main/java/mx/trackermap/TrackerMap/android/details/commands/UnitCommandsFragment.kt
index cd8d7af..9d12608 100644
--- a/androidApp/src/main/java/mx/trackermap/TrackerMap/android/details/commands/UnitCommandsFragment.kt
+++ b/androidApp/src/main/java/mx/trackermap/TrackerMap/android/details/commands/UnitCommandsFragment.kt
@@ -42,10 +42,21 @@ class UnitCommandsFragment: Fragment() {
super.onViewCreated(view, savedInstanceState)
binding.reportLoading.root.visibility = View.VISIBLE
- setupObservers()
setupEvents()
}
+ override fun onResume() {
+ super.onResume()
+
+ setupObservers()
+ }
+
+ override fun onStop() {
+ super.onStop()
+
+ removeObservers()
+ }
+
override fun onDestroyView() {
super.onDestroyView()
_binding = null
@@ -86,6 +97,10 @@ class UnitCommandsFragment: Fragment() {
unitCommandsViewModel.fetchCommands(id)
}
+ private fun removeObservers() {
+ unitCommandsViewModel.commands.removeObservers(viewLifecycleOwner)
+ }
+
private fun setupEvents() {
binding.commandsList.setOnItemClickListener { _, _, index, _ ->
Log.d("UnitCommandsFragment", "Selected item at index - $index")