- Move addAttributeColumns functional to init

- Remove empty convert functions
- Add check for undefined in some formatters

1 files changed, 15 insertions, 36 deletions

diff --git a/web/app/AttributeFormatter.js b/web/app/AttributeFormatter.js
index 9d66794..423492d 100644
--- a/web/app/AttributeFormatter.js
+++ b/web/app/AttributeFormatter.js
@@ -44,44 +44,33 @@ Ext.define('Traccar.AttributeFormatter', {
     },
 
     voltageFormatter: function (value) {
-        return Number(value.toFixed(Traccar.Style.numberPrecision)) + ' ' + Strings.sharedVoltAbbreviation;
-    },
-
-    voltageConverter: function (value) {
-        return Number(value);
+        if (value !== undefined) {
+            return Number(value.toFixed(Traccar.Style.numberPrecision)) + ' ' + Strings.sharedVoltAbbreviation;
+        }
     },
 
     percentageFormatter: function (value) {
-        return Number(value.toFixed(Traccar.Style.numberPrecision)) + ' %';
-    },
-
-    percentageConverter: function (value) {
-        return Number(value);
+        if (value !== undefined) {
+            return Number(value.toFixed(Traccar.Style.numberPrecision)) + ' %';
+        }
     },
 
     temperatureFormatter: function (value) {
-        return Number(value.toFixed(Traccar.Style.numberPrecision)) + ' °C';
-    },
-
-    temperatureConverter: function (value) {
-        return Number(value);
+        if (value !== undefined) {
+            return Number(value.toFixed(Traccar.Style.numberPrecision)) + ' °C';
+        }
     },
 
-
     volumeFormatter: function (value) {
-        return Number(value.toFixed(Traccar.Style.numberPrecision)) + ' ' + Strings.sharedLiterAbbreviation;
-    },
-
-    volumeConverter: function (value) {
-        return Number(value);
+        if (value !== undefined) {
+            return Number(value.toFixed(Traccar.Style.numberPrecision)) + ' ' + Strings.sharedLiterAbbreviation;
+        }
     },
 
     consumptionFormatter: function (value) {
-        return Number(value.toFixed(Traccar.Style.numberPrecision)) + ' ' + Strings.sharedLiterPerHourAbbreviation;
-    },
-
-    consumptionConverter: function (value) {
-        return Number(value);
+        if (value !== undefined) {
+            return Number(value.toFixed(Traccar.Style.numberPrecision)) + ' ' + Strings.sharedLiterPerHourAbbreviation;
+        }
     },
 
     hoursFormatter: function (value) {
@@ -208,16 +197,6 @@ Ext.define('Traccar.AttributeFormatter', {
                 return this.distanceConverter;
             } else if (dataType === 'speed') {
                 return this.speedConverter;
-            } else if (dataType === 'voltage') {
-                return this.voltageConverter;
-            } else if (dataType === 'percentage') {
-                return this.percentageConverter;
-            } else if (dataType === 'temperature') {
-                return this.temperatureConverter;
-            } else if (dataType === 'volume') {
-                return this.volumeConverter;
-            } else if (dataType === 'consumption') {
-                return this.consumptionConverter;
             } else {
                 return function (value) {
                     return value;