aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorScott Jackson <daneren2005@gmail.com>2013-12-04 21:15:20 -0800
committerScott Jackson <daneren2005@gmail.com>2013-12-04 21:15:20 -0800
commit61d534dc5fe78d36458022aad9ec0feffa2ebf39 (patch)
tree5cbb16b18d98adbb8285944a6cb096258e572d5c
parent3a71eece405c1ef624768fdcda0d06cc20c90ee8 (diff)
downloaddsub-61d534dc5fe78d36458022aad9ec0feffa2ebf39.tar.gz
dsub-61d534dc5fe78d36458022aad9ec0feffa2ebf39.tar.bz2
dsub-61d534dc5fe78d36458022aad9ec0feffa2ebf39.zip
#202 Increase small album art, even more for tablets
-rw-r--r--res/drawable-hdpi/unknown_album.pngbin4650 -> 7127 bytes
-rw-r--r--res/drawable-large/unknown_album.pngbin0 -> 14939 bytes
-rw-r--r--res/layout/album_list_item.xml8
-rw-r--r--res/layout/select_album_header.xml92
-rw-r--r--res/values-large/dimens.xml2
-rw-r--r--res/values/dimens.xml2
-rw-r--r--src/github/daneren2005/dsub/util/ImageLoader.java2
7 files changed, 52 insertions, 54 deletions
diff --git a/res/drawable-hdpi/unknown_album.png b/res/drawable-hdpi/unknown_album.png
index 18b664e4..9b7844f4 100644
--- a/res/drawable-hdpi/unknown_album.png
+++ b/res/drawable-hdpi/unknown_album.png
Binary files differ
diff --git a/res/drawable-large/unknown_album.png b/res/drawable-large/unknown_album.png
new file mode 100644
index 00000000..c4e32c61
--- /dev/null
+++ b/res/drawable-large/unknown_album.png
Binary files differ
diff --git a/res/layout/album_list_item.xml b/res/layout/album_list_item.xml
index 9051a72e..99a9ed88 100644
--- a/res/layout/album_list_item.xml
+++ b/res/layout/album_list_item.xml
@@ -7,11 +7,9 @@
<ImageView
android:id="@+id/album_coverart"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:layout_gravity="left|center_vertical"
- android:paddingTop="1dip"
- android:paddingBottom="1dip"/>
+ android:layout_width="@dimen/AlbumArt.Small"
+ android:layout_height="@dimen/AlbumArt.Small"
+ android:layout_gravity="left|center_vertical"/>
<LinearLayout
android:orientation="vertical"
diff --git a/res/layout/select_album_header.xml b/res/layout/select_album_header.xml
index 2bf74110..33cbf93e 100644
--- a/res/layout/select_album_header.xml
+++ b/res/layout/select_album_header.xml
@@ -7,66 +7,60 @@
<ImageView
android:id="@+id/select_album_art"
android:src="@drawable/unknown_album_large"
- android:layout_width="120dip"
- android:layout_height="120dip"
+ android:layout_width="@dimen/AlbumArt.Header"
+ android:layout_height="@dimen/AlbumArt.Header"
android:layout_alignParentTop="true"
android:layout_alignParentLeft="true"
android:layout_marginRight="10dip"
android:scaleType="fitCenter"
android:contentDescription="@null"/>
- <TextView
- android:text="This is the album title"
- android:id="@+id/select_album_title"
- android:layout_width="wrap_content"
+ <LinearLayout
+ android:layout_width="fill_parent"
android:layout_height="wrap_content"
android:layout_toRightOf="@+id/select_album_art"
- android:paddingTop="20dip"
- android:paddingBottom="8dip"
- android:paddingRight="4dip"
- android:textAppearance="?android:attr/textAppearanceMedium"
- android:textStyle="bold"
- android:singleLine="true"
- android:ellipsize="end"/>
+ android:orientation="vertical"
+ android:layout_centerVertical="true">
- <TextView
- android:text="This is the artist name"
- android:id="@+id/select_album_artist"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:layout_below="@+id/select_album_title"
- android:layout_toRightOf="@+id/select_album_art"
- android:paddingBottom="2dip"
- android:paddingRight="4dip"
- android:textAppearance="?android:attr/textAppearanceSmall"
- android:singleLine="true"
- android:ellipsize="end"/>
+ <TextView
+ android:text="This is the album title"
+ android:id="@+id/select_album_title"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:textAppearance="?android:attr/textAppearanceLarge"
+ android:textStyle="bold"
+ android:singleLine="true"
+ android:ellipsize="end"/>
- <TextView
- android:text="XX SONGS"
- android:id="@+id/select_album_song_count"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:layout_below="@+id/select_album_artist"
- android:layout_toRightOf="@+id/select_album_art"
- android:paddingRight="4dip"
- android:textAppearance="?android:attr/textAppearanceSmall"
- android:textSize="10sp"
- android:singleLine="true"
- android:ellipsize="none"/>
+ <TextView
+ android:text="This is the artist name"
+ android:id="@+id/select_album_artist"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:textAppearance="?android:attr/textAppearanceMedium"
+ android:singleLine="true"
+ android:ellipsize="end"/>
- <TextView
- android:text="0:00"
- android:id="@+id/select_album_song_length"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:layout_below="@+id/select_album_song_count"
- android:layout_toRightOf="@+id/select_album_art"
- android:paddingRight="4dip"
- android:textAppearance="?android:attr/textAppearanceSmall"
- android:textSize="10sp"
- android:singleLine="true"
- android:ellipsize="none"/>
+ <TextView
+ android:text="XX SONGS"
+ android:id="@+id/select_album_song_count"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:paddingTop="14dip"
+ android:textAppearance="?android:attr/textAppearanceSmall"
+ android:singleLine="true"
+ android:ellipsize="none"/>
+
+ <TextView
+ android:text="0:00"
+ android:id="@+id/select_album_song_length"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:textAppearance="?android:attr/textAppearanceSmall"
+ android:singleLine="true"
+ android:ellipsize="none"/>
+
+ </LinearLayout>
</RelativeLayout>
diff --git a/res/values-large/dimens.xml b/res/values-large/dimens.xml
index 4e29290d..f68b5459 100644
--- a/res/values-large/dimens.xml
+++ b/res/values-large/dimens.xml
@@ -2,4 +2,6 @@
<resources>
<dimen name="Button">64dip</dimen>
<dimen name="Button.Small">54dip</dimen>
+ <dimen name="AlbumArt.Small">96dip</dimen>
+ <dimen name="AlbumArt.Header">210dip</dimen>
</resources> \ No newline at end of file
diff --git a/res/values/dimens.xml b/res/values/dimens.xml
index b504b105..cab253e9 100644
--- a/res/values/dimens.xml
+++ b/res/values/dimens.xml
@@ -2,4 +2,6 @@
<resources>
<dimen name="Button">54dip</dimen>
<dimen name="Button.Small">46dip</dimen>
+ <dimen name="AlbumArt.Small">68dip</dimen>
+ <dimen name="AlbumArt.Header">120dip</dimen>
</resources> \ No newline at end of file
diff --git a/src/github/daneren2005/dsub/util/ImageLoader.java b/src/github/daneren2005/dsub/util/ImageLoader.java
index 9e9875aa..8653dfb7 100644
--- a/src/github/daneren2005/dsub/util/ImageLoader.java
+++ b/src/github/daneren2005/dsub/util/ImageLoader.java
@@ -66,9 +66,11 @@ public class ImageLoader implements Runnable {
this.context = context;
final int maxMemory = (int) (Runtime.getRuntime().maxMemory() / 1024);
final int cacheSize = maxMemory / 4;
+ Log.d(TAG, "Max: " + cacheSize);
cache = new LruCache<String, Bitmap>(cacheSize) {
@Override
protected int sizeOf(String key, Bitmap bitmap) {
+ Log.d(TAG, "size: " + (bitmap.getRowBytes() * bitmap.getHeight() / 1024));
return bitmap.getRowBytes() * bitmap.getHeight() / 1024;
}