From 0350d762a7c08199e79dc401b6c6821d7e2a21bd Mon Sep 17 00:00:00 2001 From: amilasilva88 Date: Thu, 13 Aug 2015 20:28:58 +0800 Subject: Added ODOMeter and Modification to Mobile UI --- web/app/store/DistanceUnits.js | 22 +++++++++++++++++++++- web/app/store/SpeedUnits.js | 6 ++++-- web/app/view/main/MainMobile.js | 5 +++++ web/app/view/report/Report.js | 9 ++++++++- web/app/view/state/StateController.js | 13 ++++++++++++- 5 files changed, 50 insertions(+), 5 deletions(-) (limited to 'web/app') diff --git a/web/app/store/DistanceUnits.js b/web/app/store/DistanceUnits.js index 506f1077c..7f0f93b70 100644 --- a/web/app/store/DistanceUnits.js +++ b/web/app/store/DistanceUnits.js @@ -20,5 +20,25 @@ Ext.define('Traccar.store.DistanceUnits', { data: [ {'key': 'km', 'name': strings.sharedKm}, {'key': 'mi', 'name': strings.sharedMi} - ] + ], + + convert: function(value, unit) { + switch (unit) { + case 'km': + value = value * 0.001; + return Math.round(value * 100) / 100; + case 'mi': + value = value * 0.000621371; + return Math.round(value * 100) / 100; + } + return value; + }, + + getUnitName: function(unit) { + if (unit) { + return this.findRecord('key', unit).get('name'); + } else { + return ''; + } + }, }); diff --git a/web/app/store/SpeedUnits.js b/web/app/store/SpeedUnits.js index 78686fbb9..934d03717 100644 --- a/web/app/store/SpeedUnits.js +++ b/web/app/store/SpeedUnits.js @@ -25,9 +25,11 @@ Ext.define('Traccar.store.SpeedUnits', { convert: function(value, unit) { switch (unit) { case 'kmh': - return value * 1.852; + value = value * 1.852; + return Math.round(value * 10) / 10; case 'mph': - return value * 1.15078; + value = value * 1.15078; + return Math.round(value * 10) / 10; } return value; }, diff --git a/web/app/view/main/MainMobile.js b/web/app/view/main/MainMobile.js index f32ad9fb1..1cdd6f525 100644 --- a/web/app/view/main/MainMobile.js +++ b/web/app/view/main/MainMobile.js @@ -40,6 +40,11 @@ Ext.define('Traccar.view.main.MainMobile', { xtype: 'deviceView', header: false, flex: 1 + },{ + region: 'east', + xtype: 'stateView', + header: false, + flex: 1 }] }); diff --git a/web/app/view/report/Report.js b/web/app/view/report/Report.js index ff8cc7b3d..f081333d4 100644 --- a/web/app/view/report/Report.js +++ b/web/app/view/report/Report.js @@ -90,7 +90,14 @@ Ext.define('Traccar.view.report.Report', { return speedUnits.convert(value, unit) + ' ' + speedUnits.getUnitName(unit); } }, - { text: strings.positionCourse, dataIndex: 'course', flex: 1 }, + /* { text: strings.positionCourse, dataIndex: 'course', flex: 1 }, */ + { text: 'ODO Meter', dataIndex: 'odoMeter', flex: 1, + renderer: function(value) { + var distanceUnits = Ext.getStore('DistanceUnits'); + var unit = Traccar.getApplication().getUser().get('distanceUnit') || Traccar.getApplication().getServer().get('distanceUnit') || ''; + return distanceUnits.convert(value, unit) + ' ' + distanceUnits.getUnitName(unit); + } + }, { text: strings.positionAddress, dataIndex: 'address', flex: 1 } ] diff --git a/web/app/view/state/StateController.js b/web/app/view/state/StateController.js index 58b63120b..858feab52 100644 --- a/web/app/view/state/StateController.js +++ b/web/app/view/state/StateController.js @@ -59,9 +59,13 @@ Ext.define('Traccar.view.state.StateController', { priority: 6, name: strings.positionSpeed }, - 'course': { +/* 'course': { priority: 7, name: strings.positionCourse + },*/ + 'odoMeter': { + priority: 7, + name: 'ODO Meter' }, 'address': { priority: 8, @@ -87,6 +91,13 @@ Ext.define('Traccar.view.state.StateController', { var unit = Traccar.getApplication().getUser().get('speedUnit') || Traccar.getApplication().getServer().get('speedUnit') || ''; value = speedUnits.convert(value, unit) + ' ' + speedUnits.getUnitName(unit); } + + if (key === 'odoMeter') { + var distanceUnits = Ext.getStore('DistanceUnits'); + var unit = Traccar.getApplication().getUser().get('distanceUnit') || Traccar.getApplication().getServer().get('distanceUnit') || ''; + value = distanceUnits.convert(value, unit) + ' ' + distanceUnits.getUnitName(unit); + } + store.add(Ext.create('Traccar.model.Parameter', { priority: this.keys[key].priority, name: this.keys[key].name, -- cgit v1.2.3 From 064cbff8e9f581bbd57988e5dd78a1f7e5480880 Mon Sep 17 00:00:00 2001 From: amilasilva88 Date: Fri, 14 Aug 2015 09:00:58 +0800 Subject: Resolved the review comments --- src/org/traccar/ODOMeterHandler.java | 7 ++++--- web/app/view/report/Report.js | 2 +- web/app/view/state/StateController.js | 2 +- web/release.html | 4 ++-- 4 files changed, 8 insertions(+), 7 deletions(-) (limited to 'web/app') diff --git a/src/org/traccar/ODOMeterHandler.java b/src/org/traccar/ODOMeterHandler.java index 1dc3aed44..87dde6b92 100644 --- a/src/org/traccar/ODOMeterHandler.java +++ b/src/org/traccar/ODOMeterHandler.java @@ -36,10 +36,11 @@ public class ODOMeterHandler extends BaseDataHandler { last.getLatitude(), last.getLongitude()); distance = Math.round((distance) * 100.0) / 100.0; double odoMeter = distance + last.getOdoMeter(); - Log.info("::: Device Course : " + position.getDeviceId() - + ", Distance :" + distance + "m, ODO Meter :" + odoMeter + " m"); +// Log.debug("::: Device Course : " + position.getDeviceId() +// + ", Distance :" + distance + "m, Odometer :" + odoMeter +// + " m"); position.setOdoMeter(odoMeter); - } + } return position; } diff --git a/web/app/view/report/Report.js b/web/app/view/report/Report.js index f081333d4..6c43b9463 100644 --- a/web/app/view/report/Report.js +++ b/web/app/view/report/Report.js @@ -91,7 +91,7 @@ Ext.define('Traccar.view.report.Report', { } }, /* { text: strings.positionCourse, dataIndex: 'course', flex: 1 }, */ - { text: 'ODO Meter', dataIndex: 'odoMeter', flex: 1, + { text: 'Odometer', dataIndex: 'odoMeter', flex: 1, renderer: function(value) { var distanceUnits = Ext.getStore('DistanceUnits'); var unit = Traccar.getApplication().getUser().get('distanceUnit') || Traccar.getApplication().getServer().get('distanceUnit') || ''; diff --git a/web/app/view/state/StateController.js b/web/app/view/state/StateController.js index 858feab52..6f222f6a8 100644 --- a/web/app/view/state/StateController.js +++ b/web/app/view/state/StateController.js @@ -65,7 +65,7 @@ Ext.define('Traccar.view.state.StateController', { },*/ 'odoMeter': { priority: 7, - name: 'ODO Meter' + name: 'Odometer' }, 'address': { priority: 8, diff --git a/web/release.html b/web/release.html index fc2ff6e87..2a4df7537 100644 --- a/web/release.html +++ b/web/release.html @@ -3,7 +3,7 @@ -BlueSky +Traccar