From 4154c2cd31f23c5d5fb336dfcd68ba192b297f93 Mon Sep 17 00:00:00 2001 From: Anton Tananaev Date: Wed, 16 Sep 2015 22:45:14 +1200 Subject: More JavaScript code cleanup --- web/app/view/device/DeviceController.js | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) (limited to 'web/app/view/device/DeviceController.js') diff --git a/web/app/view/device/DeviceController.js b/web/app/view/device/DeviceController.js index 31caa5147..59b777f8b 100644 --- a/web/app/view/device/DeviceController.js +++ b/web/app/view/device/DeviceController.js @@ -37,7 +37,7 @@ Ext.define('Traccar.view.device.DeviceController', { }, init: function() { - if (Traccar.getApplication().getUser().get('admin')) { + if (Traccar.app.getUser().get('admin')) { this.lookupReference('settingsServerButton').setHidden(false); this.lookupReference('settingsUsersButton').setHidden(false); } @@ -48,15 +48,17 @@ Ext.define('Traccar.view.device.DeviceController', { }, onAddClick: function() { - var device = Ext.create('Traccar.model.Device'); - var dialog = Ext.create('Traccar.view.device.DeviceDialog'); + var device, dialog; + device = Ext.create('Traccar.model.Device'); + dialog = Ext.create('Traccar.view.device.DeviceDialog'); dialog.down('form').loadRecord(device); dialog.show(); }, onEditClick: function() { - var device = this.getView().getSelectionModel().getSelection()[0]; - var dialog = Ext.create('Traccar.view.device.DeviceDialog'); + var device, dialog; + device = this.getView().getSelectionModel().getSelection()[0]; + dialog = Ext.create('Traccar.view.device.DeviceDialog'); dialog.down('form').loadRecord(device); dialog.show(); }, @@ -72,8 +74,9 @@ Ext.define('Traccar.view.device.DeviceController', { no: strings.sharedCancel }, fn: function(btn) { + var store; if (btn === 'yes') { - var store = Ext.getStore('Devices'); + store = Ext.getStore('Devices'); store.remove(device); store.sync(); } @@ -82,10 +85,11 @@ Ext.define('Traccar.view.device.DeviceController', { }, onCommandClick: function() { - var device = this.getView().getSelectionModel().getSelection()[0]; - var command = Ext.create('Traccar.model.Command'); + var device, command, dialog; + device = this.getView().getSelectionModel().getSelection()[0]; + command = Ext.create('Traccar.model.Command'); command.set('deviceId', device.get('id')); - var dialog = Ext.create('Traccar.view.command.CommandDialog'); + dialog = Ext.create('Traccar.view.command.CommandDialog'); dialog.down('form').loadRecord(command); dialog.show(); }, @@ -101,16 +105,14 @@ Ext.define('Traccar.view.device.DeviceController', { }, onUserClick: function() { - var user = Traccar.getApplication().getUser(); var dialog = Ext.create('Traccar.view.user.UserDialog'); - dialog.down('form').loadRecord(user); + dialog.down('form').loadRecord(Traccar.app.getUser()); dialog.show(); }, onServerClick: function() { - var server = Traccar.getApplication().getServer(); var dialog = Ext.create('Traccar.view.admin.ServerDialog'); - dialog.down('form').loadRecord(server); + dialog.down('form').loadRecord(Traccar.app.getServer()); dialog.show(); }, -- cgit v1.2.3