From 305528411520755e4b68318eab1e2feecaf96acd Mon Sep 17 00:00:00 2001 From: gustavofarias Date: Tue, 7 Feb 2017 22:39:10 -0300 Subject: Fix MXT protocol response --- src/org/traccar/protocol/MxtProtocolDecoder.java | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'src/org/traccar/protocol') diff --git a/src/org/traccar/protocol/MxtProtocolDecoder.java b/src/org/traccar/protocol/MxtProtocolDecoder.java index f6c471b19..a86fd0204 100644 --- a/src/org/traccar/protocol/MxtProtocolDecoder.java +++ b/src/org/traccar/protocol/MxtProtocolDecoder.java @@ -42,26 +42,25 @@ public class MxtProtocolDecoder extends BaseProtocolDecoder { private static void sendResponse(Channel channel, int device, long id, int crc) { if (channel != null) { ChannelBuffer response = ChannelBuffers.dynamicBuffer(ByteOrder.LITTLE_ENDIAN, 0); - response.writeByte(0x01); // header response.writeByte(device); response.writeByte(MSG_ACK); response.writeInt((int) id); response.writeShort(crc); response.writeShort(Checksum.crc16( - Checksum.CRC16_XMODEM, response.toByteBuffer(1, response.readableBytes() - 1))); - response.writeByte(0x04); // ending - channel.write(response); + Checksum.CRC16_XMODEM, response.toByteBuffer(0, response.readableBytes()))); ChannelBuffer encoded = ChannelBuffers.dynamicBuffer(); + encoded.writeByte(0x01); // header while (response.readable()) { int b = response.readByte(); - if (response.readerIndex() != 1 && response.readableBytes() != 0 - && (b == 0x01 || b == 0x04 || b == 0x10 || b == 0x11 || b == 0x13)) { + if (b == 0x01 || b == 0x04 || b == 0x10 || b == 0x11 || b == 0x13) { encoded.writeByte(0x10); b += 0x20; } - response.writeByte(b); + encoded.writeByte(b); } + encoded.writeByte(0x04); // ending + channel.write(encoded); } } -- cgit v1.2.3 From da4aa93919f113c5b9ff9c417dc8db72efea6fd1 Mon Sep 17 00:00:00 2001 From: gustavofcalmeida Date: Tue, 7 Feb 2017 23:11:55 -0300 Subject: Removed unnecessary parameters --- src/org/traccar/protocol/MxtProtocolDecoder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/org/traccar/protocol') diff --git a/src/org/traccar/protocol/MxtProtocolDecoder.java b/src/org/traccar/protocol/MxtProtocolDecoder.java index a86fd0204..eaeeacc97 100644 --- a/src/org/traccar/protocol/MxtProtocolDecoder.java +++ b/src/org/traccar/protocol/MxtProtocolDecoder.java @@ -47,7 +47,7 @@ public class MxtProtocolDecoder extends BaseProtocolDecoder { response.writeInt((int) id); response.writeShort(crc); response.writeShort(Checksum.crc16( - Checksum.CRC16_XMODEM, response.toByteBuffer(0, response.readableBytes()))); + Checksum.CRC16_XMODEM, response.toByteBuffer())); ChannelBuffer encoded = ChannelBuffers.dynamicBuffer(); encoded.writeByte(0x01); // header -- cgit v1.2.3