From 80119f59a0d4b89396f5d7d57ba2d80257a8da79 Mon Sep 17 00:00:00 2001 From: Abyss777 Date: Mon, 30 May 2016 12:07:43 +0500 Subject: - Style fixes (use lower camel case in all cases) - Added TYPE_prefix for event.type strings - Removed commented code - Removed "database.selectLastEvents" because it is not cross-database. Do the same via code. --- src/org/traccar/events/OverspeedEventHandler.java | 46 +++-------------------- 1 file changed, 6 insertions(+), 40 deletions(-) (limited to 'src/org/traccar/events/OverspeedEventHandler.java') diff --git a/src/org/traccar/events/OverspeedEventHandler.java b/src/org/traccar/events/OverspeedEventHandler.java index 706e9b905..30410ff32 100644 --- a/src/org/traccar/events/OverspeedEventHandler.java +++ b/src/org/traccar/events/OverspeedEventHandler.java @@ -6,35 +6,17 @@ import org.traccar.BaseEventHandler; import org.traccar.Context; import org.traccar.model.Event; import org.traccar.model.Position; -import org.traccar.model.Server; import org.traccar.helper.Log; -//import org.traccar.model.Device; -//import org.traccar.model.Group; import org.traccar.helper.UnitsConverter; public class OverspeedEventHandler extends BaseEventHandler { private double globalSpeedLimit; - private long suppressRepeated; + private int suppressRepeated; public OverspeedEventHandler() { - globalSpeedLimit = Context.getConfig().getInteger("event.globalspeedlimit", 0); - suppressRepeated = Context.getConfig().getLong("event.suppressrepeated", 60); - try { - Server server = Context.getDataManager().getServer(); - String speedUnit = server.getSpeedUnit(); - if (speedUnit != null) { - switch (speedUnit) { - case "kmh" : globalSpeedLimit = UnitsConverter.knotsFromKph(globalSpeedLimit); - break; - case "mph" : globalSpeedLimit = UnitsConverter.knotsFromMph(globalSpeedLimit); - default : break; - } - } - } catch (SQLException error) { - Log.warning(error); - } - + globalSpeedLimit = UnitsConverter.knotsFromKph(Context.getConfig().getInteger("event.globalSpeedLimit", 0)); + suppressRepeated = Context.getConfig().getInteger("event.suppressRepeated", 60); } @Override @@ -45,28 +27,12 @@ public class OverspeedEventHandler extends BaseEventHandler { } double speed = position.getSpeed(); boolean valid = position.getValid(); - double deviceSpeedLimit = 0; - double groupSpeedLimit = 0; -// Device device = Context.getIdentityManager().getDeviceById(position.getDeviceId()); -// if (device != null) { -// deviceSpeedLimit = device.getSpeedLimit(); -// try { -// Group group = Context.getDataManager().getGroupById(device.getGroupId()); -// if (group != null) { -// groupSpeedLimit = group.getSpeedLimit(); -// } -// } catch (SQLException error) { -// Log.warning(error); -// } -// } - if (valid && globalSpeedLimit != 0 && speed > globalSpeedLimit - || valid && groupSpeedLimit != 0 && speed > groupSpeedLimit - || valid && deviceSpeedLimit != 0 && speed > deviceSpeedLimit) { + if (valid && globalSpeedLimit != 0 && speed > globalSpeedLimit) { try { if (Context.getDataManager().getLastEvents( - position.getDeviceId(), Event.DEVICE_OVERSPEED, suppressRepeated).isEmpty()) { - event = new Event(Event.DEVICE_OVERSPEED, position.getDeviceId(), position.getId()); + position.getDeviceId(), Event.TYPE_DEVICE_OVERSPEED, suppressRepeated).isEmpty()) { + event = new Event(Event.TYPE_DEVICE_OVERSPEED, position.getDeviceId(), position.getId()); } } catch (SQLException error) { Log.warning(error); -- cgit v1.2.3