From 8a19ed9994e6bdd531faa3021711fc0e89497ca8 Mon Sep 17 00:00:00 2001
From: Abyss777 <abyss@fox5.ru>
Date: Mon, 16 Jan 2017 16:27:51 +0500
Subject: - Rename otherUserId to managedUserId - Optimize getManaged*
 functions

---
 src/org/traccar/database/PermissionsManager.java | 59 +++++++++++-------------
 1 file changed, 27 insertions(+), 32 deletions(-)

(limited to 'src/org/traccar/database/PermissionsManager.java')

diff --git a/src/org/traccar/database/PermissionsManager.java b/src/org/traccar/database/PermissionsManager.java
index 3c62f84c2..c49ffb00c 100644
--- a/src/org/traccar/database/PermissionsManager.java
+++ b/src/org/traccar/database/PermissionsManager.java
@@ -30,7 +30,6 @@ import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.HashSet;
-import java.util.Iterator;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
@@ -114,7 +113,7 @@ public class PermissionsManager {
         userPermissions.clear();
         try {
             for (UserPermission permission : dataManager.getUserPermissions()) {
-                getUserPermissions(permission.getUserId()).add(permission.getOtherUserId());
+                getUserPermissions(permission.getUserId()).add(permission.getManagedUserId());
             }
         } catch (SQLException error) {
             Log.warning(error);
@@ -250,27 +249,25 @@ public class PermissionsManager {
 
     public void checkGroup(long userId, long groupId) throws SecurityException {
         if (!getGroupPermissions(userId).contains(groupId) && !isAdmin(userId)) {
-            Iterator<Long> iterator = getUserPermissions(userId).iterator();
-            boolean managed = false;
-            while (!managed && iterator.hasNext()) {
-                managed = getGroupPermissions(iterator.next()).contains(groupId);
-            }
-            if (!managed) {
-                throw new SecurityException("Group access denied");
+            checkManager(userId);
+            for (long managedUserId : getUserPermissions(userId)) {
+                if (getGroupPermissions(managedUserId).contains(groupId)) {
+                    return;
+                }
             }
+            throw new SecurityException("Group access denied");
         }
     }
 
     public void checkDevice(long userId, long deviceId) throws SecurityException {
         if (!getDevicePermissions(userId).contains(deviceId) && !isAdmin(userId)) {
-            Iterator<Long> iterator = getUserPermissions(userId).iterator();
-            boolean managed = false;
-            while (!managed && iterator.hasNext()) {
-                managed = getDevicePermissions(iterator.next()).contains(deviceId);
-            }
-            if (!managed) {
-                throw new SecurityException("Device access denied");
+            checkManager(userId);
+            for (long managedUserId : getUserPermissions(userId)) {
+                if (getDevicePermissions(managedUserId).contains(deviceId)) {
+                    return;
+                }
             }
+            throw new SecurityException("Device access denied");
         }
     }
 
@@ -282,27 +279,25 @@ public class PermissionsManager {
 
     public void checkGeofence(long userId, long geofenceId) throws SecurityException {
         if (!Context.getGeofenceManager().checkGeofence(userId, geofenceId) && !isAdmin(userId)) {
-            Iterator<Long> iterator = getUserPermissions(userId).iterator();
-            boolean managed = false;
-            while (!managed && iterator.hasNext()) {
-                managed = Context.getGeofenceManager().checkGeofence(iterator.next(), geofenceId);
-            }
-            if (!managed) {
-                throw new SecurityException("Geofence access denied");
+            checkManager(userId);
+            for (long managedUserId : getUserPermissions(userId)) {
+                if (Context.getGeofenceManager().checkGeofence(managedUserId, geofenceId)) {
+                    return;
+                }
             }
+            throw new SecurityException("Geofence access denied");
         }
     }
 
     public void checkCalendar(long userId, long calendarId) throws SecurityException {
         if (!Context.getCalendarManager().checkCalendar(userId, calendarId) && !isAdmin(userId)) {
-            Iterator<Long> iterator = getUserPermissions(userId).iterator();
-            boolean managed = false;
-            while (!managed && iterator.hasNext()) {
-                managed = Context.getCalendarManager().checkCalendar(iterator.next(), calendarId);
-            }
-            if (!managed) {
-                throw new SecurityException("Calendar access denied");
+            checkManager(userId);
+            for (long managedUserId : getUserPermissions(userId)) {
+                if (Context.getCalendarManager().checkCalendar(managedUserId, calendarId)) {
+                    return;
+                }
             }
+            throw new SecurityException("Calendar access denied");
         }
     }
 
@@ -321,8 +316,8 @@ public class PermissionsManager {
 
     public Collection<User> getUsers(long userId) {
         Collection<User> result = new ArrayList<>();
-        for (long otherUserId : getUserPermissions(userId)) {
-            result.add(users.get(otherUserId));
+        for (long managedUserId : getUserPermissions(userId)) {
+            result.add(users.get(managedUserId));
         }
         return result;
     }
-- 
cgit v1.2.3