From 45940f73c57b871711ee9fb41ebeba3c0ca9e9b6 Mon Sep 17 00:00:00 2001
From: Anton Tananaev <anton@traccar.org>
Date: Sat, 18 Jun 2022 16:48:15 -0700
Subject: Fix offline device notifications

---
 src/main/java/org/traccar/session/ConnectionManager.java | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

(limited to 'src/main/java/org/traccar/session/ConnectionManager.java')

diff --git a/src/main/java/org/traccar/session/ConnectionManager.java b/src/main/java/org/traccar/session/ConnectionManager.java
index 05c4893fd..fe6521d18 100644
--- a/src/main/java/org/traccar/session/ConnectionManager.java
+++ b/src/main/java/org/traccar/session/ConnectionManager.java
@@ -144,7 +144,10 @@ public class ConnectionManager {
             endpointSessions.put(device.getUniqueId(), deviceSession);
             sessionsByEndpoint.put(endpoint, endpointSessions);
             sessionsByDeviceId.put(device.getId(), deviceSession);
-            cacheManager.addDevice(device.getId());
+
+            if (oldSession == null) {
+                cacheManager.addDevice(device.getId());
+            }
 
             return deviceSession;
         } else {
@@ -190,8 +193,8 @@ public class ConnectionManager {
     public void deviceUnknown(long deviceId) {
         updateDevice(deviceId, Device.STATUS_UNKNOWN, null);
         DeviceSession deviceSession = sessionsByDeviceId.remove(deviceId);
-        cacheManager.removeDevice(deviceId);
         if (deviceSession != null) {
+            cacheManager.removeDevice(deviceId);
             Endpoint endpoint = new Endpoint(deviceSession.getChannel(), deviceSession.getRemoteAddress());
             sessionsByEndpoint.computeIfPresent(endpoint, (e, sessions) -> {
                 sessions.remove(deviceSession.getUniqueId());
-- 
cgit v1.2.3