From d14cef37937fb64aa54cb497d51afd47b2798fb3 Mon Sep 17 00:00:00 2001 From: Anton Tananaev Date: Wed, 6 Jul 2016 10:01:35 +1200 Subject: Fix HuaSheng acknowledgement message --- src/org/traccar/protocol/HuaShengProtocolDecoder.java | 4 ++-- test/org/traccar/protocol/HuaShengProtocolDecoderTest.java | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/org/traccar/protocol/HuaShengProtocolDecoder.java b/src/org/traccar/protocol/HuaShengProtocolDecoder.java index ef23f9fc4..6743db47d 100644 --- a/src/org/traccar/protocol/HuaShengProtocolDecoder.java +++ b/src/org/traccar/protocol/HuaShengProtocolDecoder.java @@ -41,8 +41,8 @@ public class HuaShengProtocolDecoder extends BaseProtocolDecoder { ChannelBuffer response = ChannelBuffers.dynamicBuffer(); response.writeByte(0xC0); response.writeShort(0x0100); - response.writeShort(response.capacity()); // TODO: length - response.writeByte(type); + response.writeShort(12 + content.readableBytes()); + response.writeShort(type); response.writeShort(0); response.writeInt(1); response.writeBytes(content); diff --git a/test/org/traccar/protocol/HuaShengProtocolDecoderTest.java b/test/org/traccar/protocol/HuaShengProtocolDecoderTest.java index 09fa353b5..269064b02 100644 --- a/test/org/traccar/protocol/HuaShengProtocolDecoderTest.java +++ b/test/org/traccar/protocol/HuaShengProtocolDecoderTest.java @@ -10,6 +10,9 @@ public class HuaShengProtocolDecoderTest extends ProtocolTest { HuaShengProtocolDecoder decoder = new HuaShengProtocolDecoder(new HuaShengProtocol()); + verifyNothing(decoder, binary( + "c000000077aa0200000000000e000100143347315f48312e315f56312e30372e54000300133335353835353035303434303635380004000b3531323030303000050005010006000400070004000800050000090018383936313032353431343533333239313833360d000a000f796573696e7465726e6574c0")); + verifyNothing(decoder, binary( "c0010c003e0002000000000010020012a0014f42445f3347315f56312e302e330013a0043335353835353035303434303635380006a08701000006a0a1035fc0")); -- cgit v1.2.3