From a9ba9a58a868309a9fc83cdb8710159c7786ca32 Mon Sep 17 00:00:00 2001
From: Anton Tananaev <anton@traccar.org>
Date: Sat, 18 Nov 2023 06:00:37 -0800
Subject: Skip old event notifications (fix #5217)

---
 src/main/java/org/traccar/config/Keys.java                  |  9 +++++++++
 src/main/java/org/traccar/database/NotificationManager.java | 11 +++++++++--
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/traccar/config/Keys.java b/src/main/java/org/traccar/config/Keys.java
index e7b07791f..3059c4f4b 100644
--- a/src/main/java/org/traccar/config/Keys.java
+++ b/src/main/java/org/traccar/config/Keys.java
@@ -1167,6 +1167,15 @@ public final class Keys {
             "notificator.types",
             List.of(KeyType.CONFIG));
 
+    /**
+     * If the event time is too old, we should not send notifications. This parameter is the threshold value in
+     * milliseconds. Default value is 15 minutes.
+     */
+    public static final ConfigKey<Long> NOTIFICATOR_TIME_THRESHOLD = new LongConfigKey(
+            "notificator.timeThreshold",
+            List.of(KeyType.CONFIG),
+            15 * 60 * 1000L);
+
     /**
      * Traccar notification API key.
      */
diff --git a/src/main/java/org/traccar/database/NotificationManager.java b/src/main/java/org/traccar/database/NotificationManager.java
index 3a57788fb..03cfba418 100644
--- a/src/main/java/org/traccar/database/NotificationManager.java
+++ b/src/main/java/org/traccar/database/NotificationManager.java
@@ -58,6 +58,7 @@ public class NotificationManager {
     private final Geocoder geocoder;
 
     private final boolean geocodeOnRequest;
+    private final long timeThreshold;
 
     @Inject
     public NotificationManager(
@@ -69,6 +70,7 @@ public class NotificationManager {
         this.notificatorManager = notificatorManager;
         this.geocoder = geocoder;
         geocodeOnRequest = config.getBoolean(Keys.GEOCODER_ON_REQUEST);
+        timeThreshold = config.getLong(Keys.NOTIFICATOR_TIME_THRESHOLD);
     }
 
     private void updateEvent(Event event, Position position) {
@@ -78,6 +80,13 @@ public class NotificationManager {
             LOGGER.warn("Event save error", error);
         }
 
+        forwardEvent(event, position);
+
+        if (System.currentTimeMillis() - event.getEventTime().getTime() > timeThreshold) {
+            LOGGER.info("Skipping notifications for old event");
+            return;
+        }
+
         var notifications = cacheManager.getDeviceObjects(event.getDeviceId(), Notification.class).stream()
                 .filter(notification -> notification.getType().equals(event.getType()))
                 .filter(notification -> {
@@ -115,8 +124,6 @@ public class NotificationManager {
                 });
             });
         }
-
-        forwardEvent(event, position);
     }
 
     private void forwardEvent(Event event, Position position) {
-- 
cgit v1.2.3