Correction based on comments.

Re-write modulo256 checksum's parameter to byte array, not varargs.
Split the tests to two methods for HEADER ver1 and ver2.
Remove above-class copyrights, added top-file copyrights.
Rename parcelNumber to index.
Rename recordStartSign to recordType.
Remove crearing additional buffer for record data, use origin buffer instead.
Added check on minimal length of packet to avoid the out-of-range exceptions.

1 files changed, 3 insertions, 4 deletions

diff --git a/test/org/traccar/helper/ChecksumTest.java b/test/org/traccar/helper/ChecksumTest.java
index 737b65c62..c7c5031df 100644
--- a/test/org/traccar/helper/ChecksumTest.java
+++ b/test/org/traccar/helper/ChecksumTest.java
@@ -4,7 +4,6 @@ import org.jboss.netty.buffer.ChannelBuffer;
 import org.jboss.netty.buffer.ChannelBuffers;
 import org.junit.Assert;
 import org.junit.Test;
-import org.traccar.protocol.Arnavi4ProtocolDecoder;
 
 import java.nio.charset.StandardCharsets;
 
@@ -31,9 +30,9 @@ public class ChecksumTest {
 
     @Test
     public void testModulo256() {
-        Assert.assertEquals(0x00, Checksum.modulo256((byte)0x00));
-        Assert.assertEquals(0x00, Checksum.modulo256((byte)0x00, (byte)0x00, (byte)0x00));
-        Assert.assertEquals(0x06, Checksum.modulo256((byte)0x01, (byte)0x02, (byte)0x03));
+        Assert.assertEquals(0x00, Checksum.modulo256(new byte[] {0x00}));
+        Assert.assertEquals(0x00, Checksum.modulo256(new byte[] {0x00, 0x00, 0x00}));
+        Assert.assertEquals(0x06, Checksum.modulo256(new byte[] {0x01, 0x02, 0x03}));
     }
 
 }