Reduce locks of devices

1 files changed, 9 insertions, 5 deletions

diff --git a/src/org/traccar/database/DataManager.java b/src/org/traccar/database/DataManager.java
index b3f24383f..0dc3c5c52 100644
--- a/src/org/traccar/database/DataManager.java
+++ b/src/org/traccar/database/DataManager.java
@@ -401,9 +401,11 @@ public class DataManager implements IdentityManager {
         QueryBuilder.create(dataSource, getQuery("database.updateDeviceStatus"))
                 .setObject(device)
                 .executeUpdate();
-        Device cachedDevice = getDeviceById(device.getId());
-        cachedDevice.setStatus(device.getStatus());
-        cachedDevice.setMotion(device.getMotion());
+        if (devicesById.containsKey(device.getId())) {
+            Device cachedDevice = devicesById.get(device.getId());
+            cachedDevice.setStatus(device.getStatus());
+            cachedDevice.setMotion(device.getMotion());
+        }
     }
 
     public void removeDevice(long deviceId) throws SQLException {
@@ -512,8 +514,10 @@ public class DataManager implements IdentityManager {
                 .setDate("now", new Date())
                 .setObject(position)
                 .executeUpdate();
-        Device device = getDeviceById(position.getDeviceId());
-        device.setPositionId(position.getId());
+        if (devicesById.containsKey(position.getDeviceId())) {
+            Device cachedDevice = devicesById.get(position.getDeviceId());
+            cachedDevice.setPositionId(position.getId());
+        }
     }
 
     public Collection<Position> getLatestPositions() throws SQLException {