aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnton Tananaev <anton.tananaev@gmail.com>2015-11-01 15:47:53 +1300
committerAnton Tananaev <anton.tananaev@gmail.com>2015-11-01 15:47:53 +1300
commit671dbc55419dd20ba16951529b28fa90a59b189a (patch)
tree6d7106fa731fbab7a67c8bcaa1c9c2c3a11a0260
parent35ba8d35cacbe3e94ffef12416bd034441950d75 (diff)
downloadtrackermap-server-671dbc55419dd20ba16951529b28fa90a59b189a.tar.gz
trackermap-server-671dbc55419dd20ba16951529b28fa90a59b189a.tar.bz2
trackermap-server-671dbc55419dd20ba16951529b28fa90a59b189a.zip
Fix PMD and Findbugs issues
-rw-r--r--src/org/traccar/protocol/CastelProtocolDecoder.java4
-rw-r--r--src/org/traccar/protocol/Gps103ProtocolDecoder.java4
2 files changed, 4 insertions, 4 deletions
diff --git a/src/org/traccar/protocol/CastelProtocolDecoder.java b/src/org/traccar/protocol/CastelProtocolDecoder.java
index bf82bede1..7d4182f7c 100644
--- a/src/org/traccar/protocol/CastelProtocolDecoder.java
+++ b/src/org/traccar/protocol/CastelProtocolDecoder.java
@@ -203,10 +203,10 @@ public class CastelProtocolDecoder extends BaseProtocolDecoder {
position.set(Event.KEY_CELL, buf.readUnsignedShort());
positions.add(position);
-
- return positions;
}
+ return positions;
+
} else if (type == MSG_CC_LOGIN) {
sendResponse(channel, remoteAddress, version, id, MSG_CC_LOGIN_RESPONSE, null);
diff --git a/src/org/traccar/protocol/Gps103ProtocolDecoder.java b/src/org/traccar/protocol/Gps103ProtocolDecoder.java
index 4bf1ca15d..f3811c1d7 100644
--- a/src/org/traccar/protocol/Gps103ProtocolDecoder.java
+++ b/src/org/traccar/protocol/Gps103ProtocolDecoder.java
@@ -127,8 +127,8 @@ public class Gps103ProtocolDecoder extends BaseProtocolDecoder {
// Timezone calculation
if (utcHours != null && utcMinutes != null) {
- int deltaMinutes = (localHours - Integer.valueOf(utcHours)) * 60;
- deltaMinutes += localMinutes - Integer.valueOf(utcMinutes);
+ int deltaMinutes = (localHours - Integer.parseInt(utcHours)) * 60;
+ deltaMinutes += localMinutes - Integer.parseInt(utcMinutes);
if (deltaMinutes <= -12 * 60) {
deltaMinutes += 24 * 60;
} else if (deltaMinutes > 12 * 60) {