From f0790eba6f3194daf4677c27e8259f783aae3207 Mon Sep 17 00:00:00 2001 From: jon-stumpf Date: Fri, 10 Oct 2014 22:25:02 -0400 Subject: Made BaseProtocolDecoder members "final" as they should not change after construction. --- .../traccar/protocol/GlobalSatProtocolDecoder.java | 29 ++++------------------ 1 file changed, 5 insertions(+), 24 deletions(-) (limited to 'src/org/traccar/protocol/GlobalSatProtocolDecoder.java') diff --git a/src/org/traccar/protocol/GlobalSatProtocolDecoder.java b/src/org/traccar/protocol/GlobalSatProtocolDecoder.java index bd56fde1f..de49d0b85 100644 --- a/src/org/traccar/protocol/GlobalSatProtocolDecoder.java +++ b/src/org/traccar/protocol/GlobalSatProtocolDecoder.java @@ -24,42 +24,23 @@ import org.jboss.netty.channel.Channel; import org.jboss.netty.channel.ChannelHandlerContext; import org.traccar.BaseProtocolDecoder; import org.traccar.ServerManager; +import org.traccar.database.DataManager; import org.traccar.helper.Log; import org.traccar.model.ExtendedInfoFormatter; import org.traccar.model.Position; public class GlobalSatProtocolDecoder extends BaseProtocolDecoder { - private String format0; - private String format1; + private String format0 = "TSPRXAB27GHKLMnaicz*U!"; + private String format1 = "SARY*U!"; - public GlobalSatProtocolDecoder(ServerManager serverManager) { - super(serverManager); - - // This is now only called by test classes. - // This will be deleted in the next commit. - assert (serverManager == null); - - // Initialize format strings - format0 = "TSPRXAB27GHKLMnaicz*U!"; - format1 = "SARY*U!"; - if (getServerManager() != null) { - Properties p = getServerManager().getProperties(); - if (p.containsKey("globalsat.format0")) { - format0 = p.getProperty("globalsat.format0"); - } - if (p.containsKey("globalsat.format1")) { - format1 = p.getProperty("globalsat.format1"); - } - } + public GlobalSatProtocolDecoder(DataManager dataManager) { + super(dataManager); } public GlobalSatProtocolDecoder(ServerManager serverManager, String protocol) { super(serverManager, protocol); - // Initialize format strings - format0 = "TSPRXAB27GHKLMnaicz*U!"; - format1 = "SARY*U!"; if (getServerManager() != null) { Properties p = getServerManager().getProperties(); if (p.containsKey(protocol + ".format0")) { -- cgit v1.2.3