From f72eade8742022502e69b300296c8ac1fbf35b25 Mon Sep 17 00:00:00 2001 From: Anton Tananaev Date: Tue, 18 Dec 2012 22:31:16 +1300 Subject: Couple of small changes --- src/org/traccar/GenericPipelineFactory.java | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) (limited to 'src/org/traccar/GenericPipelineFactory.java') diff --git a/src/org/traccar/GenericPipelineFactory.java b/src/org/traccar/GenericPipelineFactory.java index 3d20ec433..556d86e1d 100644 --- a/src/org/traccar/GenericPipelineFactory.java +++ b/src/org/traccar/GenericPipelineFactory.java @@ -17,6 +17,7 @@ package org.traccar; import java.net.InetSocketAddress; import org.jboss.netty.buffer.ChannelBuffer; +import org.jboss.netty.buffer.ChannelBuffers; import org.jboss.netty.channel.*; import org.jboss.netty.handler.logging.LoggingHandler; import org.jboss.netty.handler.timeout.IdleStateHandler; @@ -63,22 +64,19 @@ public abstract class GenericPipelineFactory implements ChannelPipelineFactory { public void log(ChannelEvent e) { if (e instanceof MessageEvent) { MessageEvent event = (MessageEvent) e; - String msg = "[" + ((InetSocketAddress) e.getChannel().getLocalAddress()).getPort() + " - "; - msg += ((InetSocketAddress) event.getRemoteAddress()).getAddress().getHostAddress() + "]"; + StringBuilder msg = new StringBuilder(); + + msg.append("[").append(((InetSocketAddress) e.getChannel().getLocalAddress()).getPort()).append(" - "); + msg.append(((InetSocketAddress) event.getRemoteAddress()).getAddress().getHostAddress()).append("]"); // Append hex message if (event.getMessage() instanceof ChannelBuffer) { - ChannelBuffer buffer = (ChannelBuffer) event.getMessage(); - msg += " - (HEX: "; - for (int i = buffer.readerIndex(); i < buffer.writerIndex(); i++) { - byte b = buffer.getByte(i); - msg += HEX_CHARS.charAt((b & 0xf0) >> 4); - msg += HEX_CHARS.charAt((b & 0x0F)); - } - msg += ")"; + msg.append(" - (HEX: "); + msg.append(ChannelBuffers.hexDump((ChannelBuffer) event.getMessage())); + msg.append(")"); } - Log.fine(msg); + Log.fine(msg.toString()); } else if (e instanceof ExceptionEvent) { ExceptionEvent event = (ExceptionEvent) e; Log.warning(event.getCause().toString()); -- cgit v1.2.3