From 90ddc7b95e3879c20d6d8f7e8b96df87e0ec1f66 Mon Sep 17 00:00:00 2001 From: Anton Tananaev Date: Thu, 16 Jul 2020 19:52:16 -0700 Subject: Fix coordinates decoding --- src/main/java/org/traccar/protocol/NiotProtocolDecoder.java | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'src/main/java/org/traccar') diff --git a/src/main/java/org/traccar/protocol/NiotProtocolDecoder.java b/src/main/java/org/traccar/protocol/NiotProtocolDecoder.java index 81b6efc91..58de0d38f 100644 --- a/src/main/java/org/traccar/protocol/NiotProtocolDecoder.java +++ b/src/main/java/org/traccar/protocol/NiotProtocolDecoder.java @@ -24,6 +24,7 @@ import org.traccar.DeviceSession; import org.traccar.NetworkMessage; import org.traccar.Protocol; import org.traccar.helper.BcdUtil; +import org.traccar.helper.BitUtil; import org.traccar.helper.Checksum; import org.traccar.helper.DateBuilder; import org.traccar.helper.UnitsConverter; @@ -55,6 +56,12 @@ public class NiotProtocolDecoder extends BaseProtocolDecoder { } } + private double readCoordinate(ByteBuf buf) { + long value = buf.readUnsignedInt(); + double result = BitUtil.to(value, 31) / 1800000.0; + return BitUtil.check(value, 31) ? -result : result; + } + @Override protected Object decode( Channel channel, SocketAddress remoteAddress, Object msg) throws Exception { @@ -88,8 +95,9 @@ public class NiotProtocolDecoder extends BaseProtocolDecoder { .setSecond(BcdUtil.readInteger(buf, 2)); position.setTime(dateBuilder.getDate()); - position.setLatitude(BcdUtil.readCoordinate(buf)); - position.setLongitude(BcdUtil.readCoordinate(buf)); + position.setValid(true); + position.setLatitude(readCoordinate(buf)); + position.setLongitude(readCoordinate(buf)); position.setSpeed(UnitsConverter.knotsFromKph(BcdUtil.readInteger(buf, 4))); position.setCourse(BcdUtil.readInteger(buf, 4)); -- cgit v1.2.3