From 6fd31893cdcad94044c3db97f6bb183fd5da13a6 Mon Sep 17 00:00:00 2001 From: Anton Tananaev Date: Sun, 25 Oct 2015 12:39:13 +1300 Subject: Refactor TK103 protocol decoder --- src/org/traccar/protocol/Tk103ProtocolDecoder.java | 110 +++++++++------------ .../traccar/protocol/Tk103ProtocolDecoderTest.java | 9 +- 2 files changed, 51 insertions(+), 68 deletions(-) diff --git a/src/org/traccar/protocol/Tk103ProtocolDecoder.java b/src/org/traccar/protocol/Tk103ProtocolDecoder.java index 56d975e46..0a7ee7f01 100644 --- a/src/org/traccar/protocol/Tk103ProtocolDecoder.java +++ b/src/org/traccar/protocol/Tk103ProtocolDecoder.java @@ -24,6 +24,9 @@ import org.jboss.netty.channel.Channel; import org.traccar.BaseProtocolDecoder; import org.traccar.Context; import org.traccar.helper.BitUtil; +import org.traccar.helper.DateBuilder; +import org.traccar.helper.Parser; +import org.traccar.helper.PatternBuilder; import org.traccar.helper.UnitsConverter; import org.traccar.model.Event; import org.traccar.model.Position; @@ -34,26 +37,28 @@ public class Tk103ProtocolDecoder extends BaseProtocolDecoder { super(protocol); } - private static final Pattern PATTERN = Pattern.compile( - "(\\d+)(,)?" + // Device ID - ".{4},?" + // Command - "\\d*" + // IMEI (?) - "(\\d{2})(\\d{2})(\\d{2}),?" + // Date (YYMMDD) - "([AV]),?" + // Validity - "(\\d{2})(\\d{2}\\.\\d+)" + // Latitude (DDMM.MMMM) - "([NS]),?" + - "(\\d{3})(\\d{2}\\.\\d+)" + // Longitude (DDDMM.MMMM) - "([EW]),?" + - "(\\d+\\.\\d)(?:\\d*,)?" + // Speed - "(\\d{2})(\\d{2})(\\d{2}),?" + // Time (HHMMSS) - "(\\d+\\.?\\d{1,2}),?" + // Course - "(?:([01]{8})|([0-9a-fA-F]{8}))?,?" + // State - "(?:L([0-9a-fA-F]+))?.*\\)?"); // Odometer + private static final Pattern PATTERN = new PatternBuilder() + .number("(d+)(,)?") // device id + .expression(".{4},?") // command + .number("d*") // imei? + .number("(dd)(dd)(dd),?") // date (yymmdd) + .expression("([AV]),?") // validity + .number("(dd)(dd.d+)") // latitude + .expression("([NS]),?") + .number("(ddd)(dd.d+)") // longitude + .expression("([EW]),?") + .number("(d+.d)(?:d*,)?") // speed + .number("(dd)(dd)(dd),?") // time + .number("(d+.?d{1,2}),?") // course + .number("(?:([01]{8})|(x{8}))?,?") // state + .number("(?:L(x+))?") // odometer + .any() + .text(")").optional() + .compile(); @Override protected Object decode( - Channel channel, SocketAddress remoteAddress, Object msg) - throws Exception { + Channel channel, SocketAddress remoteAddress, Object msg) throws Exception { String sentence = (String) msg; @@ -75,83 +80,56 @@ public class Tk103ProtocolDecoder extends BaseProtocolDecoder { } } - // Parse message - Matcher parser = PATTERN.matcher(sentence); + Parser parser = new Parser(PATTERN, sentence); if (!parser.matches()) { return null; } - // Create new position Position position = new Position(); position.setProtocol(getProtocolName()); - Integer index = 1; - // Get device by IMEI - if (!identify(parser.group(index++), channel)) { + if (!identify(parser.next(), channel)) { return null; } position.setDeviceId(getDeviceId()); - // Date - Calendar time = Calendar.getInstance(TimeZone.getTimeZone("UTC")); - time.clear(); - if (parser.group(index++) == null) { - time.set(Calendar.YEAR, 2000 + Integer.parseInt(parser.group(index++))); - time.set(Calendar.MONTH, Integer.parseInt(parser.group(index++)) - 1); - time.set(Calendar.DAY_OF_MONTH, Integer.parseInt(parser.group(index++))); + DateBuilder dateBuilder = new DateBuilder(); + if (parser.next() == null) { + dateBuilder.setDate(parser.nextInt(), parser.nextInt(), parser.nextInt()); } else { - time.set(Calendar.DAY_OF_MONTH, Integer.parseInt(parser.group(index++))); - time.set(Calendar.MONTH, Integer.parseInt(parser.group(index++)) - 1); - time.set(Calendar.YEAR, 2000 + Integer.parseInt(parser.group(index++))); + dateBuilder.setDateReverse(parser.nextInt(), parser.nextInt(), parser.nextInt()); } - // Validity - position.setValid(parser.group(index++).compareTo("A") == 0); + position.setValid(parser.next().equals("A")); + position.setLatitude(parser.nextCoordinate()); + position.setLongitude(parser.nextCoordinate()); - // Latitude - Double latitude = Double.parseDouble(parser.group(index++)); - latitude += Double.parseDouble(parser.group(index++)) / 60; - if (parser.group(index++).compareTo("S") == 0) latitude = -latitude; - position.setLatitude(latitude); - - // Longitude - Double longitude = Double.parseDouble(parser.group(index++)); - longitude += Double.parseDouble(parser.group(index++)) / 60; - if (parser.group(index++).compareTo("W") == 0) longitude = -longitude; - position.setLongitude(longitude); - - // Speed if (Context.getConfig().getBoolean(getProtocolName() + ".mph")) { - position.setSpeed(UnitsConverter.knotsFromMph(Double.parseDouble(parser.group(index++)))); + position.setSpeed(UnitsConverter.knotsFromMph(parser.nextDouble())); } else { - position.setSpeed(UnitsConverter.knotsFromKph(Double.parseDouble(parser.group(index++)))); + position.setSpeed(UnitsConverter.knotsFromKph(parser.nextDouble())); } - // Time - time.set(Calendar.HOUR_OF_DAY, Integer.parseInt(parser.group(index++))); - time.set(Calendar.MINUTE, Integer.parseInt(parser.group(index++))); - time.set(Calendar.SECOND, Integer.parseInt(parser.group(index++))); - position.setTime(time.getTime()); + dateBuilder.setTime(parser.nextInt(), parser.nextInt(), parser.nextInt()); + position.setTime(dateBuilder.getDate()); - // Course - position.setCourse(Double.parseDouble(parser.group(index++))); + position.setCourse(parser.nextDouble()); - // State - String status = parser.group(index++); // binary status + // Status + String status = parser.next(); if (status != null) { - position.set(Event.KEY_STATUS, status); + position.set(Event.KEY_STATUS, status); // binary status - int value = Integer.parseInt(status, 2); + int value = Integer.parseInt(new StringBuilder(status).reverse().toString(), 2); position.set(Event.KEY_CHARGE, !BitUtil.check(value, 0)); position.set(Event.KEY_IGNITION, BitUtil.check(value, 1)); } - position.set(Event.KEY_STATUS, parser.group(index++)); // hex status + position.set(Event.KEY_STATUS, parser.next()); // hex status - // Odometer - String odometer = parser.group(index++); - if (odometer != null) { - position.set(Event.KEY_ODOMETER, Long.parseLong(odometer, 16)); + if (parser.hasNext()) { + position.set(Event.KEY_ODOMETER, parser.nextLong(16)); } + return position; } diff --git a/test/org/traccar/protocol/Tk103ProtocolDecoderTest.java b/test/org/traccar/protocol/Tk103ProtocolDecoderTest.java index 43cc56fb9..8f2cea217 100644 --- a/test/org/traccar/protocol/Tk103ProtocolDecoderTest.java +++ b/test/org/traccar/protocol/Tk103ProtocolDecoderTest.java @@ -10,6 +10,10 @@ public class Tk103ProtocolDecoderTest extends ProtocolDecoderTest { Tk103ProtocolDecoder decoder = new Tk103ProtocolDecoder(new Tk103Protocol()); + verifyPosition(decoder, text( + "(088047365460BR00151024A2555.3531S02855.3329E004.7055148276.1701000000L00009AA3)"), + position("2015-10-24 05:51:48.000", true, -25.92255, 28.92222)); + verifyPosition(decoder, text( "(088047365460BP05354188047365460150929A3258.1754S02755.4323E009.4193927301.9000000000L00000000)")); @@ -59,8 +63,9 @@ public class Tk103ProtocolDecoderTest extends ProtocolDecoderTest { "(352606090042050,BP05,240414,V,0000.0000N,00000.0000E,000.0,193133,000.0")); verifyPosition(decoder, text( - "(352606090042050,BP05,240414,A,4527.3513N,00909.9758E,4.80,112825,155.49")); - + "(352606090042050,BP05,240414,A,4527.3513N,00909.9758E,4.80,112825,155.49"), + position("2014-04-24 11:28:25.000", true, 45.45586, 9.16626)); + verifyPosition(decoder, text( "(013632782450,BP05,101201,A,2234.0297N,11405.9101E,000.0,040137,178.48,00000000,L00000000")); -- cgit v1.2.3