1 files changed, 12 insertions, 68 deletions

diff --git a/src/main/java/org/traccar/protocol/ArnaviProtocolDecoder.java b/src/main/java/org/traccar/protocol/ArnaviProtocolDecoder.java
index 7996cf429..68a70c944 100644
--- a/src/main/java/org/traccar/protocol/ArnaviProtocolDecoder.java
+++ b/src/main/java/org/traccar/protocol/ArnaviProtocolDecoder.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2015 - 2019 Anton Tananaev (anton@traccar.org)
+ * Copyright 2020 Anton Tananaev (anton@traccar.org)
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -15,91 +15,35 @@
  */
 package org.traccar.protocol;
 
+import io.netty.buffer.ByteBuf;
 import io.netty.channel.Channel;
 import org.traccar.BaseProtocolDecoder;
-import org.traccar.DeviceSession;
 import org.traccar.Protocol;
-import org.traccar.helper.DateBuilder;
-import org.traccar.helper.Parser;
-import org.traccar.helper.PatternBuilder;
-import org.traccar.model.Position;
 
 import java.net.SocketAddress;
-import java.util.regex.Pattern;
 
 public class ArnaviProtocolDecoder extends BaseProtocolDecoder {
 
+    private final ArnaviTextProtocolDecoder textProtocolDecoder;
+    private final ArnaviBinaryProtocolDecoder binaryProtocolDecoder;
+
     public ArnaviProtocolDecoder(Protocol protocol) {
         super(protocol);
+        textProtocolDecoder = new ArnaviTextProtocolDecoder(protocol);
+        binaryProtocolDecoder = new ArnaviBinaryProtocolDecoder(protocol);
     }
 
-    private static final Pattern PATTERN = new PatternBuilder()
-            .text("$AV,")
-            .number("Vd,")                       // type
-            .number("(d+),")                     // device id
-            .number("(d+),")                     // index
-            .number("(d+),")                     // power
-            .number("(d+),")                     // battery
-            .number("-?d+,")
-            .expression("[01],")                 // movement
-            .expression("([01]),")               // ignition
-            .number("(d+),")                     // input
-            .number("d+,d+,")                    // input 1
-            .number("d+,d+,").optional()         // input 2
-            .expression("[01],")                 // fix type
-            .number("(d+),")                     // satellites
-            .groupBegin()
-            .number("(d+.d+)?,")                 // altitude
-            .number("(?:d+.d+)?,")               // geoid height
-            .groupEnd("?")
-            .number("(dd)(dd)(dd),")             // time (hhmmss)
-            .number("(dd)(dd.d+)([NS]),")        // latitude
-            .number("(ddd)(dd.d+)([EW]),")       // longitude
-            .number("(d+.d+),")                  // speed
-            .number("(d+.d+),")                  // course
-            .number("(dd)(dd)(dd)")              // date (ddmmyy)
-            .any()
-            .compile();
-
     @Override
     protected Object decode(
             Channel channel, SocketAddress remoteAddress, Object msg) throws Exception {
 
-        Parser parser = new Parser(PATTERN, (String) msg);
-        if (!parser.matches()) {
-            return null;
-        }
+        ByteBuf buf = (ByteBuf) msg;
 
-        Position position = new Position(getProtocolName());
-
-        DeviceSession deviceSession = getDeviceSession(channel, remoteAddress, parser.next());
-        if (deviceSession == null) {
-            return null;
+        if (buf.getByte(buf.readerIndex()) == '$') {
+            return textProtocolDecoder.decode(channel, remoteAddress, msg);
+        } else {
+            return binaryProtocolDecoder.decode(channel, remoteAddress, msg);
         }
-        position.setDeviceId(deviceSession.getDeviceId());
-
-        position.set(Position.KEY_INDEX, parser.nextInt());
-        position.set(Position.KEY_POWER, parser.nextInt() * 0.01);
-        position.set(Position.KEY_BATTERY, parser.nextInt() * 0.01);
-        position.set(Position.KEY_IGNITION, parser.nextInt() == 1);
-        position.set(Position.KEY_INPUT, parser.nextInt());
-        position.set(Position.KEY_SATELLITES, parser.nextInt());
-
-        position.setAltitude(parser.nextDouble(0));
-
-        DateBuilder dateBuilder = new DateBuilder()
-                .setTime(parser.nextInt(), parser.nextInt(), parser.nextInt());
-
-        position.setValid(true);
-        position.setLatitude(parser.nextCoordinate());
-        position.setLongitude(parser.nextCoordinate());
-        position.setSpeed(parser.nextDouble());
-        position.setCourse(parser.nextDouble());
-
-        dateBuilder.setDateReverse(parser.nextInt(), parser.nextInt(), parser.nextInt());
-        position.setTime(dateBuilder.getDate());
-
-        return position;
     }
 
 }