diff options
author | Ivan Muratov <binakot@gmail.com> | 2017-07-14 08:48:27 +0300 |
---|---|---|
committer | Ivan Muratov <binakot@gmail.com> | 2017-07-14 08:48:27 +0300 |
commit | 50d45d27beb423c1689f83401d0adb88b7fafb65 (patch) | |
tree | 9e40c2bf7d581c8987dfa8cb562b1e8d1c831c04 /src/org/traccar/helper | |
parent | a2376cf6354a94c8bd8c8e13c4e78936d4f2ae97 (diff) | |
download | traccar-server-50d45d27beb423c1689f83401d0adb88b7fafb65.tar.gz traccar-server-50d45d27beb423c1689f83401d0adb88b7fafb65.tar.bz2 traccar-server-50d45d27beb423c1689f83401d0adb88b7fafb65.zip |
Correction based on comments.
Re-write modulo256 checksum's parameter to byte array, not varargs.
Split the tests to two methods for HEADER ver1 and ver2.
Remove above-class copyrights, added top-file copyrights.
Rename parcelNumber to index.
Rename recordStartSign to recordType.
Remove crearing additional buffer for record data, use origin buffer instead.
Added check on minimal length of packet to avoid the out-of-range exceptions.
Diffstat (limited to 'src/org/traccar/helper')
-rw-r--r-- | src/org/traccar/helper/Checksum.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/org/traccar/helper/Checksum.java b/src/org/traccar/helper/Checksum.java index 7a0151d36..44cef9635 100644 --- a/src/org/traccar/helper/Checksum.java +++ b/src/org/traccar/helper/Checksum.java @@ -243,7 +243,7 @@ public final class Checksum { return (10 - (checksum % 10)) % 10; } - public static int modulo256(byte... bytes) { + public static int modulo256(byte[] bytes) { int sum = 0; for (byte b : bytes) { sum = (sum + b) & 0xFF; |