diff options
author | Anton Tananaev <anton.tananaev@gmail.com> | 2016-03-14 14:48:39 +1300 |
---|---|---|
committer | Anton Tananaev <anton.tananaev@gmail.com> | 2016-03-14 14:48:39 +1300 |
commit | 0a1019b59481b6bf8ee8989feb23cef084b6caf5 (patch) | |
tree | 75b715e6dd70f6be3357e1710c4db6f1f6a1e29e /src/org/traccar/database | |
parent | 40bf728938311fa9619ad2bb0eb89b21c16e9585 (diff) | |
download | traccar-server-0a1019b59481b6bf8ee8989feb23cef084b6caf5.tar.gz traccar-server-0a1019b59481b6bf8ee8989feb23cef084b6caf5.tar.bz2 traccar-server-0a1019b59481b6bf8ee8989feb23cef084b6caf5.zip |
Fix PMD and CheckStyle issues
Diffstat (limited to 'src/org/traccar/database')
-rw-r--r-- | src/org/traccar/database/GroupTree.java | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/src/org/traccar/database/GroupTree.java b/src/org/traccar/database/GroupTree.java index b383b1501..4a2321f58 100644 --- a/src/org/traccar/database/GroupTree.java +++ b/src/org/traccar/database/GroupTree.java @@ -33,11 +33,11 @@ public class GroupTree { private Device device; private Collection<TreeNode> children = new HashSet<>(); - public TreeNode(Group group) { + TreeNode(Group group) { this.group = group; } - public TreeNode(Device device) { + TreeNode(Device device) { this.device = device; } @@ -59,14 +59,10 @@ public class GroupTree { if (other == this) { return true; } - if (group != null) { - if (other.group != null) { - return group.getId() == other.group.getId(); - } - } else if (device != null) { - if (other.device != null) { - return device.getId() == other.device.getId(); - } + if (group != null && other.group != null) { + return group.getId() == other.group.getId(); + } else if (device != null && other.device != null) { + return device.getId() == other.device.getId(); } return false; } |