aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOliver Schramm <oliver.schramm97@gmail.com>2021-05-26 02:19:11 +0200
committerOliver Schramm <oliver.schramm97@gmail.com>2021-05-26 02:20:29 +0200
commit4581380113a7edf67936a0d567fc469de709e508 (patch)
tree42fe02daa42b110967ea5c33906f4f94adc9ddf4
parent8d1e86a7a06f1525a64c44b262758a216b084159 (diff)
downloadtraccar-server-4581380113a7edf67936a0d567fc469de709e508.tar.gz
traccar-server-4581380113a7edf67936a0d567fc469de709e508.tar.bz2
traccar-server-4581380113a7edf67936a0d567fc469de709e508.zip
Adjust code style
-rw-r--r--src/main/java/org/traccar/protocol/MegastekProtocolDecoder.java7
-rw-r--r--src/test/java/org/traccar/protocol/MegastekProtocolDecoderTest.java3
2 files changed, 4 insertions, 6 deletions
diff --git a/src/main/java/org/traccar/protocol/MegastekProtocolDecoder.java b/src/main/java/org/traccar/protocol/MegastekProtocolDecoder.java
index 074523a76..82c616245 100644
--- a/src/main/java/org/traccar/protocol/MegastekProtocolDecoder.java
+++ b/src/main/java/org/traccar/protocol/MegastekProtocolDecoder.java
@@ -275,10 +275,7 @@ public class MegastekProtocolDecoder extends BaseProtocolDecoder {
.or().text(" ")
.groupEnd("?").text(",")
.number("(d+)?,") // rfid
- .groupBegin() // ext accessories
- .number("([01])") // charging
- .number("(d)?") // belt status
- .groupEnd("?")
+ .number("([01])(d)?").optional() // charge and belt status
.expression("[^,]*,")
.number("(d+)?,") // battery
.expression("([^,]*)[,;]") // alert
@@ -360,7 +357,7 @@ public class MegastekProtocolDecoder extends BaseProtocolDecoder {
position.set(Position.KEY_DRIVER_UNIQUE_ID, parser.next());
if (parser.hasNext()) {
- position.set(Position.KEY_CHARGE, parser.nextInt() == 1);
+ position.set(Position.KEY_CHARGE, parser.nextInt() > 0);
}
if (parser.hasNext()) {
position.set("belt", parser.nextInt());
diff --git a/src/test/java/org/traccar/protocol/MegastekProtocolDecoderTest.java b/src/test/java/org/traccar/protocol/MegastekProtocolDecoderTest.java
index b086364ab..d2201a4a9 100644
--- a/src/test/java/org/traccar/protocol/MegastekProtocolDecoderTest.java
+++ b/src/test/java/org/traccar/protocol/MegastekProtocolDecoderTest.java
@@ -54,7 +54,7 @@ public class MegastekProtocolDecoderTest extends ProtocolTest {
"0339$MGV002,860719020193193,DeviceName,R,240214,104742,A,2238.20471,N,11401.97967,E,00,03,00,1.20,0.462,356.23,137.9,1.5,460,07,262C,0F54,25,0000,0000,0,0,0,28.5,28.3,,10,100,Timer,18339df945d0:53|108c0fb0a2f1:57|e46f133d6f5c:59|108ccf109f21:59|8adc963d752a:82|04c5a48cc6c0:82|9adc963d752a:83|8800b0b00004:85|90671c80e2fc:85|80c5e68c8d36:86,;!"));
verifyPosition(decoder, text(
- "$MGV002,860719020193193,DeviceName,R,240214,104742,A,2238.20471,N,11401.97967,E,00,03,00,1.20,0.462,356.23,137.9,1.5,460,07,262C,0F54,25,0000,0000,0,0,0,28.5,28.3,,10,100,Timer;!"),
+ "$MGV002,860719020193193,DeviceName,R,240214,104742,A,2238.20471,N,11401.97967,E,00,03,00,1.20,0.462,356.23,137.9,1.5,460,07,262C,0F54,25,0000,0000,0,0,0,28.5,28.3,,,100,Timer;!"),
position("2014-02-24 10:47:42.000", true, 22.63675, 114.03299));
verifyAttribute(decoder, text(
@@ -106,6 +106,7 @@ public class MegastekProtocolDecoderTest extends ProtocolTest {
verifyPosition(decoder, text(
"LOGSTX,123456789012345,$GPRMC,230739.000,A,3841.81895,N,09494.12409,W,0.00,0.00,270914,,,A*70,L,,imei:123456789012345,0/7,269.7,Battery=100%,,0,,,5856,78A3;78"));
+
}
}