From 691994b7767fb2b4859f7e8c8ca67166259a034e Mon Sep 17 00:00:00 2001 From: Allan Wang Date: Sun, 28 Jun 2020 00:42:50 -0700 Subject: Update gradle and add bugsnag to sample app --- build.gradle | 1 + buildSrc/src/main/kotlin/kau/Versions.kt | 4 +-- gradle/wrapper/gradle-wrapper.jar | Bin 55616 -> 58910 bytes gradle/wrapper/gradle-wrapper.properties | 3 +- gradlew | 31 ++++++++++----------- gradlew.bat | 4 +++ sample/build.gradle | 5 +++- sample/src/main/AndroidManifest.xml | 3 ++ .../kotlin/ca/allanwang/kau/sample/SampleApp.kt | 16 ++++++++++- 9 files changed, 44 insertions(+), 23 deletions(-) diff --git a/build.gradle b/build.gradle index bf525cd..a2da52c 100644 --- a/build.gradle +++ b/build.gradle @@ -13,6 +13,7 @@ buildscript { dependencies { classpath Plugins.android classpath Plugins.kotlin + classpath Plugins.bugsnag classpath Plugins.androidMaven classpath Plugins.playPublisher classpath Plugins.dexCount diff --git a/buildSrc/src/main/kotlin/kau/Versions.kt b/buildSrc/src/main/kotlin/kau/Versions.kt index f0ed129..37768e5 100644 --- a/buildSrc/src/main/kotlin/kau/Versions.kt +++ b/buildSrc/src/main/kotlin/kau/Versions.kt @@ -79,10 +79,10 @@ object Versions { const val spotless = "3.28.0" // https://github.com/bugsnag/bugsnag-android/releases - const val bugsnag = "4.22.3" + const val bugsnag = "5.0.0" // https://github.com/bugsnag/bugsnag-android-gradle-plugin/releases - const val bugsnagPlugin="4.7.4" + const val bugsnagPlugin="4.7.5" // https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google const val gradlePlugin = "4.1.0-beta02" diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index 5c2d1cf..62d4c05 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 925dd20..186b715 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,6 +1,5 @@ -#Mon Jun 15 18:28:26 PDT 2020 distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists +distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-rc-1-all.zip diff --git a/gradlew b/gradlew index 83f2acf..fbd7c51 100755 --- a/gradlew +++ b/gradlew @@ -82,6 +82,7 @@ esac CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar + # Determine the Java command to use to start the JVM. if [ -n "$JAVA_HOME" ] ; then if [ -x "$JAVA_HOME/jre/sh/java" ] ; then @@ -129,6 +130,7 @@ fi if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then APP_HOME=`cygpath --path --mixed "$APP_HOME"` CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` + JAVACMD=`cygpath --unix "$JAVACMD"` # We build the pattern for arguments to be converted via cygpath @@ -154,19 +156,19 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then else eval `echo args$i`="\"$arg\"" fi - i=$((i+1)) + i=`expr $i + 1` done case $i in - (0) set -- ;; - (1) set -- "$args0" ;; - (2) set -- "$args0" "$args1" ;; - (3) set -- "$args0" "$args1" "$args2" ;; - (4) set -- "$args0" "$args1" "$args2" "$args3" ;; - (5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; - (6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; - (7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; - (8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; - (9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; + 0) set -- ;; + 1) set -- "$args0" ;; + 2) set -- "$args0" "$args1" ;; + 3) set -- "$args0" "$args1" "$args2" ;; + 4) set -- "$args0" "$args1" "$args2" "$args3" ;; + 5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; + 6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; + 7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; + 8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; + 9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; esac fi @@ -175,14 +177,9 @@ save () { for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done echo " " } -APP_ARGS=$(save "$@") +APP_ARGS=`save "$@"` # Collect all arguments for the java command, following the shell quoting and substitution rules eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" -# by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong -if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then - cd "$(dirname "$0")" -fi - exec "$JAVACMD" "$@" diff --git a/gradlew.bat b/gradlew.bat index 9618d8d..5093609 100644 --- a/gradlew.bat +++ b/gradlew.bat @@ -29,6 +29,9 @@ if "%DIRNAME%" == "" set DIRNAME=. set APP_BASE_NAME=%~n0 set APP_HOME=%DIRNAME% +@rem Resolve any "." and ".." in APP_HOME to make it shorter. +for %%i in ("%APP_HOME%") do set APP_HOME=%%~fi + @rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. set DEFAULT_JVM_OPTS="-Xmx64m" "-Xms64m" @@ -81,6 +84,7 @@ set CMD_LINE_ARGS=%* set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar + @rem Execute Gradle "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS% diff --git a/sample/build.gradle b/sample/build.gradle index d620c2a..fd07da1 100644 --- a/sample/build.gradle +++ b/sample/build.gradle @@ -4,6 +4,7 @@ apply plugin: 'com.android.application' apply plugin: 'kotlin-android' apply plugin: 'kotlin-kapt' apply plugin: 'kotlin-android-extensions' +//apply plugin: 'com.bugsnag.android.gradle' apply plugin: 'com.github.triplet.play' apply plugin: 'dagger.hilt.android.plugin' @@ -64,6 +65,7 @@ android { versionNameSuffix "-debug" signingConfig signingConfigs.debug resValue "string", "app_name", "KAU Debug" + ext.enableBugsnag = false } release { @@ -130,6 +132,8 @@ dependencies { implementation Dependencies.hilt kapt Dependencies.hiltCompiler + implementation Dependencies.bugsnag + implementation Dependencies.materialDialog("input") testImplementation Dependencies.kotlinTest @@ -137,7 +141,6 @@ dependencies { testImplementation Dependencies.hiltTest kaptTest Dependencies.hiltCompiler - androidTestImplementation Dependencies.kotlinTest androidTestImplementation Dependencies.espresso androidTestImplementation Dependencies.espresso("intents") diff --git a/sample/src/main/AndroidManifest.xml b/sample/src/main/AndroidManifest.xml index 5846c6b..b205c51 100644 --- a/sample/src/main/AndroidManifest.xml +++ b/sample/src/main/AndroidManifest.xml @@ -57,6 +57,9 @@ android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/kau_file_paths" /> + \ No newline at end of file diff --git a/sample/src/main/kotlin/ca/allanwang/kau/sample/SampleApp.kt b/sample/src/main/kotlin/ca/allanwang/kau/sample/SampleApp.kt index 282f9ff..bead882 100644 --- a/sample/src/main/kotlin/ca/allanwang/kau/sample/SampleApp.kt +++ b/sample/src/main/kotlin/ca/allanwang/kau/sample/SampleApp.kt @@ -16,10 +16,24 @@ package ca.allanwang.kau.sample import android.app.Application +import com.bugsnag.android.Bugsnag +import com.bugsnag.android.Configuration import dagger.hilt.android.HiltAndroidApp /** * Created by Allan Wang on 2017-06-08. */ @HiltAndroidApp -class SampleApp : Application() +class SampleApp : Application() { + override fun onCreate() { + super.onCreate() +// initBugsnag() + } + + private fun initBugsnag() { + if (BuildConfig.DEBUG) { + return + } + Bugsnag.start(this) + } +} -- cgit v1.2.3 From e4e538ed8dd488271378c99caf4418bf28d10508 Mon Sep 17 00:00:00 2001 From: Allan Wang Date: Sun, 28 Jun 2020 00:44:40 -0700 Subject: Downgrade bugsnag --- buildSrc/src/main/kotlin/kau/Versions.kt | 2 +- sample/src/main/kotlin/ca/allanwang/kau/sample/SampleApp.kt | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/buildSrc/src/main/kotlin/kau/Versions.kt b/buildSrc/src/main/kotlin/kau/Versions.kt index 37768e5..f01f6b8 100644 --- a/buildSrc/src/main/kotlin/kau/Versions.kt +++ b/buildSrc/src/main/kotlin/kau/Versions.kt @@ -79,7 +79,7 @@ object Versions { const val spotless = "3.28.0" // https://github.com/bugsnag/bugsnag-android/releases - const val bugsnag = "5.0.0" + const val bugsnag = "4.22.3" // https://github.com/bugsnag/bugsnag-android-gradle-plugin/releases const val bugsnagPlugin="4.7.5" diff --git a/sample/src/main/kotlin/ca/allanwang/kau/sample/SampleApp.kt b/sample/src/main/kotlin/ca/allanwang/kau/sample/SampleApp.kt index bead882..fd1a2e7 100644 --- a/sample/src/main/kotlin/ca/allanwang/kau/sample/SampleApp.kt +++ b/sample/src/main/kotlin/ca/allanwang/kau/sample/SampleApp.kt @@ -17,7 +17,6 @@ package ca.allanwang.kau.sample import android.app.Application import com.bugsnag.android.Bugsnag -import com.bugsnag.android.Configuration import dagger.hilt.android.HiltAndroidApp /** @@ -34,6 +33,6 @@ class SampleApp : Application() { if (BuildConfig.DEBUG) { return } - Bugsnag.start(this) + Bugsnag.init(this) } } -- cgit v1.2.3