From 8245f835b6e5711b3363851ef70e156ae001bda3 Mon Sep 17 00:00:00 2001 From: Allan Wang Date: Tue, 1 Jan 2019 17:21:26 -0500 Subject: Close channels after destroy, resolves #1292 --- .../kotlin/com/pitchedapps/frost/activities/BaseMainActivity.kt | 4 ++-- .../main/kotlin/com/pitchedapps/frost/activities/MainActivity.kt | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) (limited to 'app/src/main/kotlin/com/pitchedapps/frost/activities') diff --git a/app/src/main/kotlin/com/pitchedapps/frost/activities/BaseMainActivity.kt b/app/src/main/kotlin/com/pitchedapps/frost/activities/BaseMainActivity.kt index 13253bcf..0f3a1e52 100644 --- a/app/src/main/kotlin/com/pitchedapps/frost/activities/BaseMainActivity.kt +++ b/app/src/main/kotlin/com/pitchedapps/frost/activities/BaseMainActivity.kt @@ -485,10 +485,10 @@ abstract class BaseMainActivity : BaseActivity(), MainActivityContract, } override fun onDestroy() { - fragmentChannel.close() - headerBadgeChannel.close() controlWebview?.destroy() super.onDestroy() + fragmentChannel.close() + headerBadgeChannel.close() } override fun collapseAppBar() { diff --git a/app/src/main/kotlin/com/pitchedapps/frost/activities/MainActivity.kt b/app/src/main/kotlin/com/pitchedapps/frost/activities/MainActivity.kt index 9a0c6270..230c1a55 100644 --- a/app/src/main/kotlin/com/pitchedapps/frost/activities/MainActivity.kt +++ b/app/src/main/kotlin/com/pitchedapps/frost/activities/MainActivity.kt @@ -66,7 +66,11 @@ class MainActivity : BaseMainActivity() { } } }) - viewPager.post { fragmentChannel.offer(0); lastPosition = 0 } //trigger hook so title is set + viewPager.post { + if (!fragmentChannel.isClosedForSend) + fragmentChannel.offer(0) + lastPosition = 0 + } //trigger hook so title is set } private fun setupTabs() { -- cgit v1.2.3