From ec157026deea7b72ff233a20c0ed40fa548f75d6 Mon Sep 17 00:00:00 2001
From: Iván Ávalos <avalos@disroot.org>
Date: Fri, 20 May 2022 23:21:37 -0500
Subject: - [shared] unitsFlow exposed to allow access to unfiltered units. -
 [android] Improved memory usage by using unitsFlow in map. - [ios] Not
 rewritten yet, filter won't work.

---
 .../TrackerMap/android/devices/DevicesFragment.kt    |  2 +-
 .../TrackerMap/android/units/UnitsViewModel.kt       | 20 +++++++++++++++++---
 .../TrackerMap/controllers/UnitsController.kt        |  2 +-
 3 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/androidApp/src/main/java/mx/trackermap/TrackerMap/android/devices/DevicesFragment.kt b/androidApp/src/main/java/mx/trackermap/TrackerMap/android/devices/DevicesFragment.kt
index e5143cb..6e1b1c6 100644
--- a/androidApp/src/main/java/mx/trackermap/TrackerMap/android/devices/DevicesFragment.kt
+++ b/androidApp/src/main/java/mx/trackermap/TrackerMap/android/devices/DevicesFragment.kt
@@ -90,7 +90,7 @@ class DevicesFragment : Fragment() {
     @DelicateCoroutinesApi
     private fun setupObservers() {
         Log.d("DevicesFragment", "setupObservers()")
-        unitsViewModel.units.observe(viewLifecycleOwner) { units ->
+        unitsViewModel.displayedUnits.observe(viewLifecycleOwner) { units ->
             Log.d("DevicesFragment", "Success $units")
             binding.infoLoading.root.visibility = View.GONE
             (binding.devicesList.adapter as DevicesAdapter).setData(units)
diff --git a/androidApp/src/main/java/mx/trackermap/TrackerMap/android/units/UnitsViewModel.kt b/androidApp/src/main/java/mx/trackermap/TrackerMap/android/units/UnitsViewModel.kt
index 174d55e..b537c0b 100644
--- a/androidApp/src/main/java/mx/trackermap/TrackerMap/android/units/UnitsViewModel.kt
+++ b/androidApp/src/main/java/mx/trackermap/TrackerMap/android/units/UnitsViewModel.kt
@@ -54,6 +54,7 @@ class UnitsViewModel(
     private var _searchQuery = savedStateHandle.getLiveData("searchQuery", "")
     private var _unitsDisplayMode = MutableLiveData(UnitsDisplayMode.MAP)
     private var _units = MutableLiveData<List<UnitInformation>>()
+    private var _displayedUnits = MutableLiveData<List<UnitInformation>>()
     private var _oldSelectedUnit = MutableLiveData<UnitInformation?>()
     private var _selectedUnit = MutableLiveData<UnitInformation?>()
     private var _mapLayerType = MutableLiveData<MapLayer.Type>()
@@ -63,6 +64,7 @@ class UnitsViewModel(
     val searchQuery: LiveData<String> get() = _searchQuery
     val unitsDisplayMode: LiveData<UnitsDisplayMode> get() = _unitsDisplayMode
     val units: LiveData<List<UnitInformation>> get() = _units
+    val displayedUnits: LiveData<List<UnitInformation>> get() = _displayedUnits
     val oldSelectedUnit: LiveData<UnitInformation?> get() = _oldSelectedUnit
     val selectedUnit: LiveData<UnitInformation?> get() = _selectedUnit
     val mapLayerType: LiveData<MapLayer.Type> get() = _mapLayerType
@@ -73,16 +75,27 @@ class UnitsViewModel(
         Log.d("UnitsViewModel", "Initializing Units View Model")
         unitsController.fetchUnits(viewModelScope)
         viewModelScope.launch {
-            setupObservers()
+            setupUnitsObserver()
         }
+        viewModelScope.launch {
+            setupDisplayedUnitsObserver()
+        }
+
         viewModelScope.launch {
             setupGeofenceObserver()
         }
     }
 
-    private suspend fun setupObservers() {
-        Log.d("UnitsViewModel", "Setup observers")
+    private suspend fun setupUnitsObserver() {
         unitsController.displayedUnitsFlow.collect { units ->
+            Log.d("UnitsViewModel", "Collecting units")
+            this._displayedUnits.value = units
+        }
+    }
+
+    private suspend fun setupDisplayedUnitsObserver() {
+        unitsController.unitsFlow.collect { units ->
+            Log.d("UnitsViewModel", "Collecting displayed units")
             this._units.value = units
             updateSelectedUnit()
         }
@@ -90,6 +103,7 @@ class UnitsViewModel(
 
     private suspend fun setupGeofenceObserver() {
         geofenceController.geofencesFlow.collect {
+            Log.d("UnitsViewModel", "Collecting geofences")
             this._geofences.postValue(it)
         }
     }
diff --git a/shared/src/commonMain/kotlin/mx/trackermap/TrackerMap/controllers/UnitsController.kt b/shared/src/commonMain/kotlin/mx/trackermap/TrackerMap/controllers/UnitsController.kt
index 8c36d50..529ca1b 100644
--- a/shared/src/commonMain/kotlin/mx/trackermap/TrackerMap/controllers/UnitsController.kt
+++ b/shared/src/commonMain/kotlin/mx/trackermap/TrackerMap/controllers/UnitsController.kt
@@ -46,7 +46,7 @@ class UnitsController(
     }
 
     val displayedUnitsFlow = MutableStateFlow<List<UnitInformation>>(emptyList())
-    private val unitsFlow = MutableStateFlow<List<UnitInformation>>(emptyList())
+    val unitsFlow = MutableStateFlow<List<UnitInformation>>(emptyList())
     private val queryFlow = MutableStateFlow("")
 
     init {
-- 
cgit v1.2.3