From eea8e3cde73b7fe2640c6fe187ffb4d899381a60 Mon Sep 17 00:00:00 2001 From: Alexander Menk Date: Mon, 19 Dec 2016 14:53:16 +0100 Subject: #2702 [WIP] Implement SET_TIMEZONE for watch Protocol Problem: Positive time zone needs to be + prepended, custom formatter does not seem to be called --- web/app/view/CommandDialog.js | 14 ++++++++++++++ web/app/view/CommandDialogController.js | 10 ++++++++++ 2 files changed, 24 insertions(+) (limited to 'web/app') diff --git a/web/app/view/CommandDialog.js b/web/app/view/CommandDialog.js index af36f55..cb6fed2 100644 --- a/web/app/view/CommandDialog.js +++ b/web/app/view/CommandDialog.js @@ -89,6 +89,20 @@ Ext.define('Traccar.view.CommandDialog', { name: 'message', hidden: true }] + }, { + xtype: 'fieldcontainer', + reference: 'paramSetTimezone', + name: 'attributes', + hidden: true, + + items: [{ + xtype: 'numberfield', + fieldLabel: Strings.commandTimezoneOffset, + name: 'timezone', + minValue: -12, + step: 0.5, + maxValue: +14 + }] }, { xtype: 'textfield', reference: 'paramCustom', diff --git a/web/app/view/CommandDialogController.js b/web/app/view/CommandDialogController.js index 9442e4f..ca50361 100644 --- a/web/app/view/CommandDialogController.js +++ b/web/app/view/CommandDialogController.js @@ -28,6 +28,8 @@ Ext.define('Traccar.view.CommandDialogController', { selected.getValue() !== 'sendSms' && selected.getValue() !== 'sendUssd'); this.lookupReference('paramSmsMessage').setHidden( selected.getValue() !== 'sendSms'); + this.lookupReference('paramSetTimezone').setHidden( + selected.getValue() !== 'setTimezone'); this.lookupReference('paramCustom').setHidden( selected.getValue() !== 'custom'); }, @@ -78,6 +80,14 @@ Ext.define('Traccar.view.CommandDialogController', { }); } + if (record.get('type') === 'setTimezone') { + attributes = this.lookupReference('paramSetTimezone'); + value = attributes.down('numberfield[name="timezone"]').getValue(); + record.set('attributes', { + timezone: value + }); + } + if (record.get('type') === 'custom') { value = this.lookupReference('paramCustom').getValue(); record.set('attributes', { -- cgit v1.2.3 From c14eda96bc3d7ebbd36f325d648087fdf4ae6572 Mon Sep 17 00:00:00 2001 From: Alexander Menk Date: Tue, 20 Dec 2016 08:41:59 +0100 Subject: #2702Implement setHearts for watch Protocol Using this function you can display a certain amount of hearts on the watch. Nothing more, nothing less. --- web/app/view/CommandDialog.js | 13 +++++++++++++ web/app/view/CommandDialogController.js | 10 ++++++++++ web/l10n/de.json | 1 + web/l10n/en.json | 1 + 4 files changed, 25 insertions(+) (limited to 'web/app') diff --git a/web/app/view/CommandDialog.js b/web/app/view/CommandDialog.js index cb6fed2..1450dc2 100644 --- a/web/app/view/CommandDialog.js +++ b/web/app/view/CommandDialog.js @@ -103,6 +103,19 @@ Ext.define('Traccar.view.CommandDialog', { step: 0.5, maxValue: +14 }] + }, { + xtype: 'fieldcontainer', + reference: 'paramSetHearts', + name: 'attributes', + hidden: true, + + items: [{ + xtype: 'numberfield', + fieldLabel: Strings.commandHearts, + name: 'hearts', + minValue: 0, + maxValue: 99 + }] }, { xtype: 'textfield', reference: 'paramCustom', diff --git a/web/app/view/CommandDialogController.js b/web/app/view/CommandDialogController.js index ca50361..c719b5e 100644 --- a/web/app/view/CommandDialogController.js +++ b/web/app/view/CommandDialogController.js @@ -30,6 +30,8 @@ Ext.define('Traccar.view.CommandDialogController', { selected.getValue() !== 'sendSms'); this.lookupReference('paramSetTimezone').setHidden( selected.getValue() !== 'setTimezone'); + this.lookupReference('paramSetHearts').setHidden( + selected.getValue() !== 'setHearts'); this.lookupReference('paramCustom').setHidden( selected.getValue() !== 'custom'); }, @@ -88,6 +90,14 @@ Ext.define('Traccar.view.CommandDialogController', { }); } + if (record.get('type') === 'setHearts') { + attributes = this.lookupReference('paramSetHearts'); + value = attributes.down('numberfield[name="hearts"]').getValue(); + record.set('attributes', { + hearts: value + }); + } + if (record.get('type') === 'custom') { value = this.lookupReference('paramCustom').getValue(); record.set('attributes', { diff --git a/web/l10n/de.json b/web/l10n/de.json index e8c8671..c0b3653 100644 --- a/web/l10n/de.json +++ b/web/l10n/de.json @@ -145,6 +145,7 @@ "commandPhone": "Rufnummer", "commandMessage": "Nachricht", "commandTimezoneOffset": "Zeitverschiebung zu UTC", + "commandHearts": "Herzen / Blumen", "eventAll": "Alle Ereignisse", "eventDeviceOnline": "Gerät ist online", "eventDeviceOffline": "Gerät ist offline", diff --git a/web/l10n/en.json b/web/l10n/en.json index e7ff00b..23b75de 100644 --- a/web/l10n/en.json +++ b/web/l10n/en.json @@ -145,6 +145,7 @@ "commandPhone": "Phone Number", "commandMessage": "Message", "commandTimezoneOffset": "Timezone Offset to UTC", + "commandHearts": "Hearts / Flowers", "eventAll": "All Events", "eventDeviceOnline": "Device is online", "eventDeviceOffline": "Device is offline", -- cgit v1.2.3 From d3cf54f1f77b3552b4f12fbde73463159cf1b359 Mon Sep 17 00:00:00 2001 From: Alexander Menk Date: Tue, 20 Dec 2016 11:00:21 +0100 Subject: #2702 Rename "Hearts" function to "Indicator" to be more general --- web/app/view/CommandDialog.js | 6 +++--- web/app/view/CommandDialogController.js | 12 ++++++------ web/l10n/en.json | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) (limited to 'web/app') diff --git a/web/app/view/CommandDialog.js b/web/app/view/CommandDialog.js index 1450dc2..ffe9095 100644 --- a/web/app/view/CommandDialog.js +++ b/web/app/view/CommandDialog.js @@ -105,14 +105,14 @@ Ext.define('Traccar.view.CommandDialog', { }] }, { xtype: 'fieldcontainer', - reference: 'paramSetHearts', + reference: 'paramSetIndicator', name: 'attributes', hidden: true, items: [{ xtype: 'numberfield', - fieldLabel: Strings.commandHearts, - name: 'hearts', + fieldLabel: Strings.commandData, + name: 'data', minValue: 0, maxValue: 99 }] diff --git a/web/app/view/CommandDialogController.js b/web/app/view/CommandDialogController.js index c719b5e..9d7bb2b 100644 --- a/web/app/view/CommandDialogController.js +++ b/web/app/view/CommandDialogController.js @@ -30,8 +30,8 @@ Ext.define('Traccar.view.CommandDialogController', { selected.getValue() !== 'sendSms'); this.lookupReference('paramSetTimezone').setHidden( selected.getValue() !== 'setTimezone'); - this.lookupReference('paramSetHearts').setHidden( - selected.getValue() !== 'setHearts'); + this.lookupReference('paramSetIndicator').setHidden( + selected.getValue() !== 'setIndicator'); this.lookupReference('paramCustom').setHidden( selected.getValue() !== 'custom'); }, @@ -90,11 +90,11 @@ Ext.define('Traccar.view.CommandDialogController', { }); } - if (record.get('type') === 'setHearts') { - attributes = this.lookupReference('paramSetHearts'); - value = attributes.down('numberfield[name="hearts"]').getValue(); + if (record.get('type') === 'setIndicator') { + attributes = this.lookupReference('paramSetIndicator'); + value = attributes.down('numberfield[name="data"]').getValue(); record.set('attributes', { - hearts: value + data: value }); } diff --git a/web/l10n/en.json b/web/l10n/en.json index 23b75de..b700cf4 100644 --- a/web/l10n/en.json +++ b/web/l10n/en.json @@ -145,7 +145,7 @@ "commandPhone": "Phone Number", "commandMessage": "Message", "commandTimezoneOffset": "Timezone Offset to UTC", - "commandHearts": "Hearts / Flowers", + "commandSetIndicator": "Set Indicator", "eventAll": "All Events", "eventDeviceOnline": "Device is online", "eventDeviceOffline": "Device is offline", -- cgit v1.2.3 From 07716fdd0bc9fb5329f2a6cd80acb6106b9f4e7c Mon Sep 17 00:00:00 2001 From: Alexander Menk Date: Tue, 20 Dec 2016 12:03:09 +0100 Subject: #2702 SetTimezone: Rename String, Reordering --- web/app/view/CommandDialog.js | 2 +- web/l10n/en.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'web/app') diff --git a/web/app/view/CommandDialog.js b/web/app/view/CommandDialog.js index ffe9095..24e0e19 100644 --- a/web/app/view/CommandDialog.js +++ b/web/app/view/CommandDialog.js @@ -97,7 +97,7 @@ Ext.define('Traccar.view.CommandDialog', { items: [{ xtype: 'numberfield', - fieldLabel: Strings.commandTimezoneOffset, + fieldLabel: Strings.commandTimezone, name: 'timezone', minValue: -12, step: 0.5, diff --git a/web/l10n/en.json b/web/l10n/en.json index b700cf4..220c1d6 100644 --- a/web/l10n/en.json +++ b/web/l10n/en.json @@ -136,6 +136,7 @@ "commandSosNumber": "Set SOS Number", "commandSilenceTime": "Set Silence Time", "commandSetPhonebook": "Set Phonebook", + "commandSetIndicator": "Set Indicator", "commandVoiceMessage": "Voice Message", "commandOutputControl": "Output Control", "commandAlarmSpeed": "Overspeed Alarm", @@ -144,8 +145,7 @@ "commandData": "Data", "commandPhone": "Phone Number", "commandMessage": "Message", - "commandTimezoneOffset": "Timezone Offset to UTC", - "commandSetIndicator": "Set Indicator", + "commandTimezone": "Timezone Offset", "eventAll": "All Events", "eventDeviceOnline": "Device is online", "eventDeviceOffline": "Device is offline", -- cgit v1.2.3 From 34fdca37d4a5a2d058345c60af028acad4edf8d8 Mon Sep 17 00:00:00 2001 From: Alexander Menk Date: Tue, 20 Dec 2016 12:47:19 +0100 Subject: #2702 SetTimezone: Conversion to Seconds, Formating improvement (+ sign) --- web/app/view/CommandDialogController.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'web/app') diff --git a/web/app/view/CommandDialogController.js b/web/app/view/CommandDialogController.js index 9d7bb2b..e6823d3 100644 --- a/web/app/view/CommandDialogController.js +++ b/web/app/view/CommandDialogController.js @@ -86,7 +86,7 @@ Ext.define('Traccar.view.CommandDialogController', { attributes = this.lookupReference('paramSetTimezone'); value = attributes.down('numberfield[name="timezone"]').getValue(); record.set('attributes', { - timezone: value + timezone: value * 60 }); } -- cgit v1.2.3 From c7d69869cd13f9d0434703e5eef60a29aba8de90 Mon Sep 17 00:00:00 2001 From: Alexander Menk Date: Wed, 21 Dec 2016 09:45:02 +0100 Subject: #2702 SetTimezone: Really - Conversion to Seconds NOT Minutes --- web/app/view/CommandDialogController.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'web/app') diff --git a/web/app/view/CommandDialogController.js b/web/app/view/CommandDialogController.js index e6823d3..6e809fa 100644 --- a/web/app/view/CommandDialogController.js +++ b/web/app/view/CommandDialogController.js @@ -86,7 +86,7 @@ Ext.define('Traccar.view.CommandDialogController', { attributes = this.lookupReference('paramSetTimezone'); value = attributes.down('numberfield[name="timezone"]').getValue(); record.set('attributes', { - timezone: value * 60 + timezone: value * 3600 }); } -- cgit v1.2.3