From ad74d97866a4c39c90ae2577be204d0f43933a7b Mon Sep 17 00:00:00 2001 From: Abyss777 Date: Fri, 21 Jul 2017 11:26:53 +0500 Subject: Use singe path for permissions --- web/app/view/edit/DevicesController.js | 3 --- web/app/view/edit/GroupsController.js | 3 --- web/app/view/edit/UsersController.js | 7 ------- web/app/view/permissions/BaseController.js | 4 ++-- 4 files changed, 2 insertions(+), 15 deletions(-) diff --git a/web/app/view/edit/DevicesController.js b/web/app/view/edit/DevicesController.js index 48c5f5b..9de298c 100644 --- a/web/app/view/edit/DevicesController.js +++ b/web/app/view/edit/DevicesController.js @@ -73,7 +73,6 @@ Ext.define('Traccar.view.edit.DevicesController', { baseObjectName: 'deviceId', linkObjectName: 'geofenceId', storeName: 'Geofences', - urlApi: 'api/devices/geofences', baseObject: device.getId() } }).show(); @@ -88,7 +87,6 @@ Ext.define('Traccar.view.edit.DevicesController', { baseObjectName: 'deviceId', linkObjectName: 'attributeId', storeName: 'ComputedAttributes', - urlApi: 'api/devices/attributes', baseObject: device.getId() } }).show(); @@ -103,7 +101,6 @@ Ext.define('Traccar.view.edit.DevicesController', { baseObjectName: 'deviceId', linkObjectName: 'driverId', storeName: 'Drivers', - urlApi: 'api/devices/drivers', baseObject: device.getId() } }).show(); diff --git a/web/app/view/edit/GroupsController.js b/web/app/view/edit/GroupsController.js index 9ced956..21f17ff 100644 --- a/web/app/view/edit/GroupsController.js +++ b/web/app/view/edit/GroupsController.js @@ -43,7 +43,6 @@ Ext.define('Traccar.view.edit.GroupsController', { baseObjectName: 'groupId', linkObjectName: 'geofenceId', storeName: admin ? 'AllGeofences' : 'Geofences', - urlApi: 'api/groups/geofences', baseObject: group.getId() } }).show(); @@ -60,7 +59,6 @@ Ext.define('Traccar.view.edit.GroupsController', { baseObjectName: 'groupId', linkObjectName: 'attributeId', storeName: admin ? 'AllComputedAttributes' : 'ComputedAttributes', - urlApi: 'api/groups/attributes', baseObject: group.getId() } }).show(); @@ -77,7 +75,6 @@ Ext.define('Traccar.view.edit.GroupsController', { baseObjectName: 'groupId', linkObjectName: 'driverId', storeName: admin ? 'AllDrivers' : 'Drivers', - urlApi: 'api/groups/drivers', baseObject: group.getId() } }).show(); diff --git a/web/app/view/edit/UsersController.js b/web/app/view/edit/UsersController.js index 1fa17df..fb7a36e 100644 --- a/web/app/view/edit/UsersController.js +++ b/web/app/view/edit/UsersController.js @@ -77,7 +77,6 @@ Ext.define('Traccar.view.edit.UsersController', { linkObjectName: 'deviceId', storeName: 'AllDevices', linkStoreName: 'Devices', - urlApi: 'api/permissions/devices', baseObject: user.getId() } }).show(); @@ -93,7 +92,6 @@ Ext.define('Traccar.view.edit.UsersController', { linkObjectName: 'groupId', storeName: 'AllGroups', linkStoreName: 'Groups', - urlApi: 'api/permissions/groups', baseObject: user.getId() } }).show(); @@ -109,7 +107,6 @@ Ext.define('Traccar.view.edit.UsersController', { linkObjectName: 'geofenceId', storeName: 'AllGeofences', linkStoreName: 'Geofences', - urlApi: 'api/permissions/geofences', baseObject: user.getId() } }).show(); @@ -136,7 +133,6 @@ Ext.define('Traccar.view.edit.UsersController', { linkObjectName: 'calendarId', storeName: 'AllCalendars', linkStoreName: 'Calendars', - urlApi: 'api/permissions/calendars', baseObject: user.getId() } }).show(); @@ -151,7 +147,6 @@ Ext.define('Traccar.view.edit.UsersController', { baseObjectName: 'userId', linkObjectName: 'managedUserId', storeName: 'Users', - urlApi: 'api/permissions/users', baseObject: user.getId() } }).show(); @@ -167,7 +162,6 @@ Ext.define('Traccar.view.edit.UsersController', { linkObjectName: 'attributeId', storeName: 'AllComputedAttributes', linkStoreName: 'ComputedAttributes', - urlApi: 'api/permissions/attributes', baseObject: user.getId() } }).show(); @@ -183,7 +177,6 @@ Ext.define('Traccar.view.edit.UsersController', { linkObjectName: 'driverId', storeName: 'AllDrivers', linkStoreName: 'Drivers', - urlApi: 'api/permissions/drivers', baseObject: user.getId() } }).show(); diff --git a/web/app/view/permissions/BaseController.js b/web/app/view/permissions/BaseController.js index 8a85a5e..860a29b 100644 --- a/web/app/view/permissions/BaseController.js +++ b/web/app/view/permissions/BaseController.js @@ -53,7 +53,7 @@ Ext.define('Traccar.view.permissions.BaseController', { data[this.getView().linkObjectName] = record.getId(); Ext.Ajax.request({ scope: this, - url: this.getView().urlApi, + url: 'api/permissions', jsonData: Ext.util.JSON.encode(data), callback: function (options, success, response) { if (!success) { @@ -71,7 +71,7 @@ Ext.define('Traccar.view.permissions.BaseController', { Ext.Ajax.request({ scope: this, method: 'DELETE', - url: this.getView().urlApi, + url: 'api/permissions', jsonData: Ext.util.JSON.encode(data), callback: function (options, success, response) { if (!success) { -- cgit v1.2.3 From 58919b078db6c163f47bcf03dcc576bb5c3ac56f Mon Sep 17 00:00:00 2001 From: Abyss777 Date: Fri, 21 Jul 2017 18:42:41 +0500 Subject: Fix adding new device if Geofences column visible --- web/app/view/edit/Devices.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/web/app/view/edit/Devices.js b/web/app/view/edit/Devices.js index d601800..d5e6d5f 100644 --- a/web/app/view/edit/Devices.js +++ b/web/app/view/edit/Devices.js @@ -161,9 +161,11 @@ Ext.define('Traccar.view.edit.Devices', { }, renderer: function (value) { var i, result = ''; - for (i = 0; i < value.length; i++) { - result += Traccar.AttributeFormatter.geofenceIdFormatter(value[i]); - result += (i < value.length - 1) ? ', ' : ''; + if (Ext.isArray(value)) { + for (i = 0; i < value.length; i++) { + result += Traccar.AttributeFormatter.geofenceIdFormatter(value[i]); + result += (i < value.length - 1) ? ', ' : ''; + } } return result; } -- cgit v1.2.3