From c6b392e681e1eabc88f0b8875c46b2400f9ca9ab Mon Sep 17 00:00:00 2001 From: Scott Jackson Date: Sat, 7 Jun 2014 13:14:16 -0700 Subject: #171 Add missing icons --- res/drawable-mdpi/ic_menu_add_person_dark.png | Bin 0 -> 652 bytes res/drawable-mdpi/ic_menu_add_person_light.png | Bin 0 -> 811 bytes res/drawable-mdpi/ic_menu_admin_dark.png | Bin 0 -> 781 bytes res/drawable-mdpi/ic_menu_admin_light.png | Bin 0 -> 966 bytes 4 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 res/drawable-mdpi/ic_menu_add_person_dark.png create mode 100644 res/drawable-mdpi/ic_menu_add_person_light.png create mode 100644 res/drawable-mdpi/ic_menu_admin_dark.png create mode 100644 res/drawable-mdpi/ic_menu_admin_light.png (limited to 'res/drawable-mdpi') diff --git a/res/drawable-mdpi/ic_menu_add_person_dark.png b/res/drawable-mdpi/ic_menu_add_person_dark.png new file mode 100644 index 00000000..7d64f5d3 Binary files /dev/null and b/res/drawable-mdpi/ic_menu_add_person_dark.png differ diff --git a/res/drawable-mdpi/ic_menu_add_person_light.png b/res/drawable-mdpi/ic_menu_add_person_light.png new file mode 100644 index 00000000..55c38c26 Binary files /dev/null and b/res/drawable-mdpi/ic_menu_add_person_light.png differ diff --git a/res/drawable-mdpi/ic_menu_admin_dark.png b/res/drawable-mdpi/ic_menu_admin_dark.png new file mode 100644 index 00000000..f88f5f15 Binary files /dev/null and b/res/drawable-mdpi/ic_menu_admin_dark.png differ diff --git a/res/drawable-mdpi/ic_menu_admin_light.png b/res/drawable-mdpi/ic_menu_admin_light.png new file mode 100644 index 00000000..35cd14f4 Binary files /dev/null and b/res/drawable-mdpi/ic_menu_admin_light.png differ -- cgit v1.2.3 From 2b079541a39f08be590cb2b37e2d401edcb4f13e Mon Sep 17 00:00:00 2001 From: Scott Jackson Date: Tue, 10 Jun 2014 20:17:37 -0700 Subject: #171 Add ability to change email, email/password to UserFragment --- res/drawable-hdpi/ic_menu_password_dark.png | Bin 0 -> 843 bytes res/drawable-hdpi/ic_menu_password_light.png | Bin 0 -> 958 bytes res/drawable-mdpi/ic_menu_password_dark.png | Bin 0 -> 554 bytes res/drawable-mdpi/ic_menu_password_light.png | Bin 0 -> 676 bytes res/drawable-xhdpi/ic_menu_password_dark.png | Bin 0 -> 1067 bytes res/drawable-xhdpi/ic_menu_password_light.png | Bin 0 -> 1234 bytes res/drawable-xxhdpi/ic_menu_password_dark.png | Bin 0 -> 1610 bytes res/drawable-xxhdpi/ic_menu_password_light.png | Bin 0 -> 1852 bytes res/layout/change_email.xml | 28 ++++ res/menu/admin_context.xml | 4 + res/menu/user.xml | 10 ++ res/menu/user_user.xml | 14 ++ res/values/attrs.xml | 1 + res/values/strings.xml | 5 + res/values/themes.xml | 3 + .../daneren2005/dsub/fragments/AdminFragment.java | 98 +---------- .../daneren2005/dsub/fragments/UserFragment.java | 58 +++---- .../dsub/service/CachedMusicService.java | 9 + .../daneren2005/dsub/service/MusicService.java | 2 + .../dsub/service/OfflineMusicService.java | 5 + .../daneren2005/dsub/service/RESTMusicService.java | 10 ++ src/github/daneren2005/dsub/util/UserUtil.java | 184 ++++++++++++++++++++- 22 files changed, 302 insertions(+), 129 deletions(-) create mode 100644 res/drawable-hdpi/ic_menu_password_dark.png create mode 100644 res/drawable-hdpi/ic_menu_password_light.png create mode 100644 res/drawable-mdpi/ic_menu_password_dark.png create mode 100644 res/drawable-mdpi/ic_menu_password_light.png create mode 100644 res/drawable-xhdpi/ic_menu_password_dark.png create mode 100644 res/drawable-xhdpi/ic_menu_password_light.png create mode 100644 res/drawable-xxhdpi/ic_menu_password_dark.png create mode 100644 res/drawable-xxhdpi/ic_menu_password_light.png create mode 100644 res/layout/change_email.xml create mode 100644 res/menu/user_user.xml (limited to 'res/drawable-mdpi') diff --git a/res/drawable-hdpi/ic_menu_password_dark.png b/res/drawable-hdpi/ic_menu_password_dark.png new file mode 100644 index 00000000..67fa3e84 Binary files /dev/null and b/res/drawable-hdpi/ic_menu_password_dark.png differ diff --git a/res/drawable-hdpi/ic_menu_password_light.png b/res/drawable-hdpi/ic_menu_password_light.png new file mode 100644 index 00000000..bd99c01f Binary files /dev/null and b/res/drawable-hdpi/ic_menu_password_light.png differ diff --git a/res/drawable-mdpi/ic_menu_password_dark.png b/res/drawable-mdpi/ic_menu_password_dark.png new file mode 100644 index 00000000..74d0095a Binary files /dev/null and b/res/drawable-mdpi/ic_menu_password_dark.png differ diff --git a/res/drawable-mdpi/ic_menu_password_light.png b/res/drawable-mdpi/ic_menu_password_light.png new file mode 100644 index 00000000..159f7889 Binary files /dev/null and b/res/drawable-mdpi/ic_menu_password_light.png differ diff --git a/res/drawable-xhdpi/ic_menu_password_dark.png b/res/drawable-xhdpi/ic_menu_password_dark.png new file mode 100644 index 00000000..d1fc0a97 Binary files /dev/null and b/res/drawable-xhdpi/ic_menu_password_dark.png differ diff --git a/res/drawable-xhdpi/ic_menu_password_light.png b/res/drawable-xhdpi/ic_menu_password_light.png new file mode 100644 index 00000000..1cbf085c Binary files /dev/null and b/res/drawable-xhdpi/ic_menu_password_light.png differ diff --git a/res/drawable-xxhdpi/ic_menu_password_dark.png b/res/drawable-xxhdpi/ic_menu_password_dark.png new file mode 100644 index 00000000..a7cd1a6d Binary files /dev/null and b/res/drawable-xxhdpi/ic_menu_password_dark.png differ diff --git a/res/drawable-xxhdpi/ic_menu_password_light.png b/res/drawable-xxhdpi/ic_menu_password_light.png new file mode 100644 index 00000000..5670a209 Binary files /dev/null and b/res/drawable-xxhdpi/ic_menu_password_light.png differ diff --git a/res/layout/change_email.xml b/res/layout/change_email.xml new file mode 100644 index 00000000..8b74215c --- /dev/null +++ b/res/layout/change_email.xml @@ -0,0 +1,28 @@ + + + + + + + + + + \ No newline at end of file diff --git a/res/menu/admin_context.xml b/res/menu/admin_context.xml index 8cd04859..922a24a9 100644 --- a/res/menu/admin_context.xml +++ b/res/menu/admin_context.xml @@ -2,6 +2,10 @@ + + diff --git a/res/menu/user.xml b/res/menu/user.xml index ace011b1..aea881fc 100644 --- a/res/menu/user.xml +++ b/res/menu/user.xml @@ -8,6 +8,16 @@ android:icon="?attr/save" compat:showAsAction="always|withText"/> + + + + diff --git a/res/menu/user_user.xml b/res/menu/user_user.xml new file mode 100644 index 00000000..f66aa793 --- /dev/null +++ b/res/menu/user_user.xml @@ -0,0 +1,14 @@ + + + + + + + \ No newline at end of file diff --git a/res/values/attrs.xml b/res/values/attrs.xml index b820c371..ac535487 100644 --- a/res/values/attrs.xml +++ b/res/values/attrs.xml @@ -22,5 +22,6 @@ + diff --git a/res/values/strings.xml b/res/values/strings.xml index 460e46db..d43d8c7b 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -450,6 +450,11 @@ Update Permissions Successfully updated permission for %1$s Failed to update permissions for %1$s + Change Email + Successfully changed email for %1$s + Failed to change email for %1$s + New Email: + Enter a valid email Change Password Successfully changed password for %1$s Failed to change password for %1$s diff --git a/res/values/themes.xml b/res/values/themes.xml index 0f464baa..6611cff7 100644 --- a/res/values/themes.xml +++ b/res/values/themes.xml @@ -25,6 +25,7 @@ @drawable/ic_menu_bookmark_light @drawable/ic_menu_share_light @drawable/ic_menu_add_person_light + @drawable/ic_menu_password_light @array/drawerItemIconsLight @style/DSub.TextViewStyle @style/DSub.ButtonStyle.Light @@ -55,6 +56,7 @@ @drawable/ic_menu_bookmark_dark @drawable/ic_menu_share_dark @drawable/ic_menu_add_person_dark + @drawable/ic_menu_password_dark @array/drawerItemIconsDark @style/DSub.TextViewStyle @style/DSub.ButtonStyle.Dark @@ -88,6 +90,7 @@ @drawable/ic_menu_bookmark_dark @drawable/ic_menu_share_dark @drawable/ic_menu_add_person_dark + @drawable/ic_menu_password_dark @array/drawerItemIconsDark @style/DSub.TextViewStyle @style/DSub.ButtonStyle.Dark diff --git a/src/github/daneren2005/dsub/fragments/AdminFragment.java b/src/github/daneren2005/dsub/fragments/AdminFragment.java index b7f09532..e0989e43 100644 --- a/src/github/daneren2005/dsub/fragments/AdminFragment.java +++ b/src/github/daneren2005/dsub/fragments/AdminFragment.java @@ -53,7 +53,7 @@ public class AdminFragment extends SelectListFragment { super.onCreateContextMenu(menu, view, menuInfo); MenuInflater inflater = context.getMenuInflater(); - if(UserUtil.isCurrentAdmin(context) && Util.checkServerVersion(context, "1.10")) { + if(UserUtil.isCurrentAdmin()) { inflater.inflate(R.menu.admin_context, menu); } else { inflater.inflate(R.menu.admin_context_user, menu); @@ -66,11 +66,14 @@ public class AdminFragment extends SelectListFragment { User user = objects.get(info.position); switch(menuItem.getItemId()) { + case R.id.admin_change_email: + UserUtil.changeEmail(context, user); + break; case R.id.admin_change_password: - changePassword(user); + UserUtil.changePassword(context, user); break; case R.id.admin_delete_user: - deleteUser(user); + UserUtil.deleteUser(context, user, adapter); break; } @@ -79,7 +82,7 @@ public class AdminFragment extends SelectListFragment { @Override public int getOptionsMenu() { - if(UserUtil.isCurrentAdmin(context)) { + if(UserUtil.isCurrentAdmin()) { return R.menu.admin; } else { return R.menu.empty; @@ -125,91 +128,4 @@ public class AdminFragment extends SelectListFragment { replaceFragment(fragment); } - - private void changePassword(final User user) { - View layout = context.getLayoutInflater().inflate(R.layout.change_password, null); - final TextView passwordView = (TextView) layout.findViewById(R.id.new_password); - - AlertDialog.Builder builder = new AlertDialog.Builder(context); - builder.setTitle(R.string.admin_change_password) - .setView(layout) - .setPositiveButton(R.string.common_save, new DialogInterface.OnClickListener() { - @Override - public void onClick(DialogInterface dialog, int id) { - final String password = passwordView.getText().toString(); - // Don't allow blank passwords - if ("".equals(password)) { - Util.toast(context, R.string.admin_change_password_invalid); - return; - } - - new SilentBackgroundTask(context) { - @Override - protected Void doInBackground() throws Throwable { - MusicService musicService = MusicServiceFactory.getMusicService(context); - musicService.changePassword(user.getUsername(), password, context, null); - return null; - } - - @Override - protected void done(Void v) { - Util.toast(context, context.getResources().getString(R.string.admin_change_password_success, user.getUsername())); - } - - @Override - protected void error(Throwable error) { - String msg; - if (error instanceof OfflineException || error instanceof ServerTooOldException) { - msg = getErrorMessage(error); - } else { - msg = context.getResources().getString(R.string.admin_change_password_error, user.getUsername()); - } - - Util.toast(context, msg); - } - }.execute(); - } - }) - .setNegativeButton(R.string.common_cancel, null) - .setCancelable(true); - - AlertDialog dialog = builder.create(); - dialog.show(); - } - - private void deleteUser(final User user) { - Util.confirmDialog(context, R.string.common_delete, user.getUsername(), new DialogInterface.OnClickListener() { - @Override - public void onClick(DialogInterface dialog, int which) { - new SilentBackgroundTask(context) { - @Override - protected Void doInBackground() throws Throwable { - MusicService musicService = MusicServiceFactory.getMusicService(context); - musicService.deleteUser(user.getUsername(), context, null); - return null; - } - - @Override - protected void done(Void v) { - adapter.remove(user); - adapter.notifyDataSetChanged(); - - Util.toast(context, context.getResources().getString(R.string.admin_delete_user_success, user.getUsername())); - } - - @Override - protected void error(Throwable error) { - String msg; - if (error instanceof OfflineException || error instanceof ServerTooOldException) { - msg = getErrorMessage(error); - } else { - msg = context.getResources().getString(R.string.admin_delete_user_error, user.getUsername()); - } - - Util.toast(context, msg); - } - }.execute(); - } - }); - } } diff --git a/src/github/daneren2005/dsub/fragments/UserFragment.java b/src/github/daneren2005/dsub/fragments/UserFragment.java index f2af85fb..6423ebcd 100644 --- a/src/github/daneren2005/dsub/fragments/UserFragment.java +++ b/src/github/daneren2005/dsub/fragments/UserFragment.java @@ -15,6 +15,9 @@ package github.daneren2005.dsub.fragments; +import android.app.Activity; +import android.app.AlertDialog; +import android.content.DialogInterface; import android.os.Bundle; import android.support.v4.widget.SwipeRefreshLayout; import android.view.LayoutInflater; @@ -24,8 +27,10 @@ import android.view.MenuItem; import android.view.View; import android.view.ViewGroup; import android.widget.ListView; +import android.widget.TextView; import github.daneren2005.dsub.R; +import github.daneren2005.dsub.activity.SubsonicActivity; import github.daneren2005.dsub.domain.User; import github.daneren2005.dsub.service.MusicService; import github.daneren2005.dsub.service.MusicServiceFactory; @@ -39,12 +44,10 @@ import github.daneren2005.dsub.view.SettingsAdapter; public class UserFragment extends SubsonicFragment{ private ListView listView; - private LayoutInflater inflater; private User user; @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle bundle) { - this.inflater = inflater; rootView = inflater.inflate(R.layout.abstract_list_fragment, container, false); refreshLayout = (SwipeRefreshLayout) rootView.findViewById(R.id.refresh_layout); @@ -54,23 +57,30 @@ public class UserFragment extends SubsonicFragment{ user = (User) args.getSerializable(Constants.INTENT_EXTRA_NAME_ID); listView = (ListView)rootView.findViewById(R.id.fragment_list); - listView.setAdapter(new SettingsAdapter(context, user.getSettings(), UserUtil.isCurrentAdmin(context))); + listView.setAdapter(new SettingsAdapter(context, user.getSettings(), UserUtil.isCurrentAdmin())); setTitle(user.getUsername()); return rootView; } + @Override + public void onAttach(Activity activity) { + super.onAttach(activity); + activity.invalidateOptionsMenu(); + } + @Override public void onCreateOptionsMenu(Menu menu, MenuInflater menuInflater) { - if(!primaryFragment) { + // For some reason this is called before onAttach + if(!primaryFragment || context == null) { return; } - if(UserUtil.isCurrentAdmin(context)) { + if(UserUtil.isCurrentAdmin() && Util.checkServerVersion(context, "1.10")) { menuInflater.inflate(R.menu.user, menu); } else { - menuInflater.inflate(R.menu.empty, menu); + menuInflater.inflate(R.menu.user_user, menu); } } @@ -82,38 +92,16 @@ public class UserFragment extends SubsonicFragment{ switch (item.getItemId()) { case R.id.menu_update_permissions: - updateSettings(); + UserUtil.updateSettings(context, user); + return true; + case R.id.menu_change_password: + UserUtil.changePassword(context, user); + return true; + case R.id.menu_change_email: + UserUtil.changeEmail(context, user); return true; } return false; } - - private void updateSettings() { - new SilentBackgroundTask(context) { - @Override - protected Void doInBackground() throws Throwable { - MusicService musicService = MusicServiceFactory.getMusicService(context); - musicService.updateUser(user, context, null); - return null; - } - - @Override - protected void done(Void v) { - Util.toast(context, context.getResources().getString(R.string.admin_update_permissions_success, user.getUsername())); - } - - @Override - protected void error(Throwable error) { - String msg; - if (error instanceof OfflineException || error instanceof ServerTooOldException) { - msg = getErrorMessage(error); - } else { - msg = context.getResources().getString(R.string.admin_update_permissions_error, user.getUsername()); - } - - Util.toast(context, msg); - } - }.execute(); - } } diff --git a/src/github/daneren2005/dsub/service/CachedMusicService.java b/src/github/daneren2005/dsub/service/CachedMusicService.java index 86289511..0049e0ac 100644 --- a/src/github/daneren2005/dsub/service/CachedMusicService.java +++ b/src/github/daneren2005/dsub/service/CachedMusicService.java @@ -562,6 +562,15 @@ public class CachedMusicService implements MusicService { file.delete(); } + @Override + public void changeEmail(String username, String email, Context context, ProgressListener progressListener) throws Exception { + musicService.changeEmail(username, email, context, progressListener); + + // Delete cached users if any have been removed from list + File file = new File(context.getCacheDir(), getCacheName(context, "users")); + file.delete(); + } + @Override public void changePassword(String username, String password, Context context, ProgressListener progressListener) throws Exception { musicService.changePassword(username, password, context, progressListener); diff --git a/src/github/daneren2005/dsub/service/MusicService.java b/src/github/daneren2005/dsub/service/MusicService.java index 6f58603c..dc760f86 100644 --- a/src/github/daneren2005/dsub/service/MusicService.java +++ b/src/github/daneren2005/dsub/service/MusicService.java @@ -172,6 +172,8 @@ public interface MusicService { void deleteUser(String username, Context context, ProgressListener progressListener) throws Exception; + void changeEmail(String username, String email, Context context, ProgressListener progressListener) throws Exception; + void changePassword(String username, String password, Context context, ProgressListener progressListener) throws Exception; Bitmap getAvatar(String username, Context context, ProgressListener progressListener) throws Exception; diff --git a/src/github/daneren2005/dsub/service/OfflineMusicService.java b/src/github/daneren2005/dsub/service/OfflineMusicService.java index 9e2b9e13..75a090c6 100644 --- a/src/github/daneren2005/dsub/service/OfflineMusicService.java +++ b/src/github/daneren2005/dsub/service/OfflineMusicService.java @@ -715,6 +715,11 @@ public class OfflineMusicService extends RESTMusicService { throw new OfflineException("Deleting users not available in offline mode"); } + @Override + public void changeEmail(String username, String email, Context context, ProgressListener progressListener) throws Exception { + throw new OfflineException("Changing email not available in offline mode"); + } + @Override public void changePassword(String username, String password, Context context, ProgressListener progressListener) throws Exception { throw new OfflineException("Changing passwords not available in offline mode"); diff --git a/src/github/daneren2005/dsub/service/RESTMusicService.java b/src/github/daneren2005/dsub/service/RESTMusicService.java index c2f64dad..371e309c 100644 --- a/src/github/daneren2005/dsub/service/RESTMusicService.java +++ b/src/github/daneren2005/dsub/service/RESTMusicService.java @@ -1263,6 +1263,16 @@ public class RESTMusicService implements MusicService { } } + @Override + public void changeEmail(String username, String email, Context context, ProgressListener progressListener) throws Exception { + Reader reader = getReader(context, progressListener, "updateUser", null, Arrays.asList("username", "email"), Arrays.asList(username, email)); + try { + new ErrorParser(context).parse(reader); + } finally { + Util.close(reader); + } + } + @Override public void changePassword(String username, String password, Context context, ProgressListener progressListener) throws Exception { Reader reader = getReader(context, progressListener, "changePassword", null, Arrays.asList("username", "password"), Arrays.asList(username, password)); diff --git a/src/github/daneren2005/dsub/util/UserUtil.java b/src/github/daneren2005/dsub/util/UserUtil.java index 5158829c..60243731 100644 --- a/src/github/daneren2005/dsub/util/UserUtil.java +++ b/src/github/daneren2005/dsub/util/UserUtil.java @@ -15,14 +15,24 @@ package github.daneren2005.dsub.util; +import android.app.Activity; +import android.app.AlertDialog; import android.content.Context; +import android.content.DialogInterface; import android.content.SharedPreferences; +import android.view.View; +import android.widget.Adapter; +import android.widget.ArrayAdapter; +import android.widget.TextView; import java.io.File; import github.daneren2005.dsub.R; import github.daneren2005.dsub.domain.User; +import github.daneren2005.dsub.service.MusicService; import github.daneren2005.dsub.service.MusicServiceFactory; +import github.daneren2005.dsub.service.OfflineException; +import github.daneren2005.dsub.service.ServerTooOldException; public final class UserUtil { private static User currentUser; @@ -55,15 +65,15 @@ public final class UserUtil { return getCurrentUsername(context, Util.getActiveServer(context)); } - public static boolean isCurrentAdmin(Context context) { + public static boolean isCurrentAdmin() { if(currentUser == null) { return false; } else { - return isCurrentRole(context, "adminRole"); + return isCurrentRole("adminRole"); } } - public static boolean isCurrentRole(Context context, String role) { + public static boolean isCurrentRole(String role) { if(currentUser == null) { return false; } @@ -76,4 +86,172 @@ public final class UserUtil { return false; } + + public static void changePassword(final Activity context, final User user) { + View layout = context.getLayoutInflater().inflate(R.layout.change_password, null); + final TextView passwordView = (TextView) layout.findViewById(R.id.new_password); + + AlertDialog.Builder builder = new AlertDialog.Builder(context); + builder.setTitle(R.string.admin_change_password) + .setView(layout) + .setPositiveButton(R.string.common_save, new DialogInterface.OnClickListener() { + @Override + public void onClick(DialogInterface dialog, int id) { + final String password = passwordView.getText().toString(); + // Don't allow blank passwords + if ("".equals(password)) { + Util.toast(context, R.string.admin_change_password_invalid); + return; + } + + new SilentBackgroundTask(context) { + @Override + protected Void doInBackground() throws Throwable { + MusicService musicService = MusicServiceFactory.getMusicService(context); + musicService.changePassword(user.getUsername(), password, context, null); + return null; + } + + @Override + protected void done(Void v) { + Util.toast(context, context.getResources().getString(R.string.admin_change_password_success, user.getUsername())); + } + + @Override + protected void error(Throwable error) { + String msg; + if (error instanceof OfflineException || error instanceof ServerTooOldException) { + msg = getErrorMessage(error); + } else { + msg = context.getResources().getString(R.string.admin_change_password_error, user.getUsername()); + } + + Util.toast(context, msg); + } + }.execute(); + } + }) + .setNegativeButton(R.string.common_cancel, null) + .setCancelable(true); + + AlertDialog dialog = builder.create(); + dialog.show(); + } + + public static void updateSettings(final Context context, final User user) { + new SilentBackgroundTask(context) { + @Override + protected Void doInBackground() throws Throwable { + MusicService musicService = MusicServiceFactory.getMusicService(context); + musicService.updateUser(user, context, null); + return null; + } + + @Override + protected void done(Void v) { + Util.toast(context, context.getResources().getString(R.string.admin_update_permissions_success, user.getUsername())); + } + + @Override + protected void error(Throwable error) { + String msg; + if (error instanceof OfflineException || error instanceof ServerTooOldException) { + msg = getErrorMessage(error); + } else { + msg = context.getResources().getString(R.string.admin_update_permissions_error, user.getUsername()); + } + + Util.toast(context, msg); + } + }.execute(); + } + + public static void changeEmail(final Activity context, final User user) { + View layout = context.getLayoutInflater().inflate(R.layout.change_email, null); + final TextView emailView = (TextView) layout.findViewById(R.id.new_email); + + AlertDialog.Builder builder = new AlertDialog.Builder(context); + builder.setTitle(R.string.admin_change_email) + .setView(layout) + .setPositiveButton(R.string.common_save, new DialogInterface.OnClickListener() { + @Override + public void onClick(DialogInterface dialog, int id) { + final String email = emailView.getText().toString(); + // Don't allow blank emails + if ("".equals(email)) { + Util.toast(context, R.string.admin_change_email_invalid); + return; + } + + new SilentBackgroundTask(context) { + @Override + protected Void doInBackground() throws Throwable { + MusicService musicService = MusicServiceFactory.getMusicService(context); + musicService.changeEmail(user.getUsername(), email, context, null); + return null; + } + + @Override + protected void done(Void v) { + Util.toast(context, context.getResources().getString(R.string.admin_change_email_success, user.getUsername())); + } + + @Override + protected void error(Throwable error) { + String msg; + if (error instanceof OfflineException || error instanceof ServerTooOldException) { + msg = getErrorMessage(error); + } else { + msg = context.getResources().getString(R.string.admin_change_email_error, user.getUsername()); + } + + Util.toast(context, msg); + } + }.execute(); + } + }) + .setNegativeButton(R.string.common_cancel, null) + .setCancelable(true); + + AlertDialog dialog = builder.create(); + dialog.show(); + } + + public static void deleteUser(final Context context, final User user, final ArrayAdapter adapter) { + Util.confirmDialog(context, R.string.common_delete, user.getUsername(), new DialogInterface.OnClickListener() { + @Override + public void onClick(DialogInterface dialog, int which) { + new SilentBackgroundTask(context) { + @Override + protected Void doInBackground() throws Throwable { + MusicService musicService = MusicServiceFactory.getMusicService(context); + musicService.deleteUser(user.getUsername(), context, null); + return null; + } + + @Override + protected void done(Void v) { + if(adapter != null) { + adapter.remove(user); + adapter.notifyDataSetChanged(); + } + + Util.toast(context, context.getResources().getString(R.string.admin_delete_user_success, user.getUsername())); + } + + @Override + protected void error(Throwable error) { + String msg; + if (error instanceof OfflineException || error instanceof ServerTooOldException) { + msg = getErrorMessage(error); + } else { + msg = context.getResources().getString(R.string.admin_delete_user_error, user.getUsername()); + } + + Util.toast(context, msg); + } + }.execute(); + } + }); + } } -- cgit v1.2.3 From feabbbf4f5919932e6446978af328dbbef2cf37f Mon Sep 17 00:00:00 2001 From: Scott Jackson Date: Tue, 10 Jun 2014 22:27:38 -0700 Subject: #171 Add avatars to Admin tab --- res/drawable-hdpi/ic_social_person.png | Bin 0 -> 4518 bytes res/drawable-mdpi/ic_social_person.png | Bin 0 -> 2834 bytes res/drawable-xhdpi/ic_social_person.png | Bin 0 -> 5960 bytes res/drawable-xxhdpi/ic_social_person.png | Bin 0 -> 9169 bytes res/layout/user_header.xml | 57 ++++++++++++++++++++ res/layout/user_list_item.xml | 45 ++++++++++++++++ .../daneren2005/dsub/fragments/AdminFragment.java | 2 +- .../daneren2005/dsub/fragments/UserFragment.java | 23 ++++++++ .../dsub/service/CachedMusicService.java | 4 +- .../daneren2005/dsub/service/MusicService.java | 2 +- .../dsub/service/OfflineMusicService.java | 2 +- .../daneren2005/dsub/service/RESTMusicService.java | 53 +++++++++++++++++- src/github/daneren2005/dsub/util/FileUtil.java | 28 ++++++++++ src/github/daneren2005/dsub/util/ImageLoader.java | 59 +++++++++++++++++++-- src/github/daneren2005/dsub/view/UserAdapter.java | 7 ++- src/github/daneren2005/dsub/view/UserView.java | 14 +++-- 16 files changed, 277 insertions(+), 19 deletions(-) create mode 100644 res/drawable-hdpi/ic_social_person.png create mode 100644 res/drawable-mdpi/ic_social_person.png create mode 100644 res/drawable-xhdpi/ic_social_person.png create mode 100644 res/drawable-xxhdpi/ic_social_person.png create mode 100644 res/layout/user_header.xml create mode 100644 res/layout/user_list_item.xml (limited to 'res/drawable-mdpi') diff --git a/res/drawable-hdpi/ic_social_person.png b/res/drawable-hdpi/ic_social_person.png new file mode 100644 index 00000000..0a0a5ff2 Binary files /dev/null and b/res/drawable-hdpi/ic_social_person.png differ diff --git a/res/drawable-mdpi/ic_social_person.png b/res/drawable-mdpi/ic_social_person.png new file mode 100644 index 00000000..c09313d8 Binary files /dev/null and b/res/drawable-mdpi/ic_social_person.png differ diff --git a/res/drawable-xhdpi/ic_social_person.png b/res/drawable-xhdpi/ic_social_person.png new file mode 100644 index 00000000..ed333afe Binary files /dev/null and b/res/drawable-xhdpi/ic_social_person.png differ diff --git a/res/drawable-xxhdpi/ic_social_person.png b/res/drawable-xxhdpi/ic_social_person.png new file mode 100644 index 00000000..f81dc6a4 Binary files /dev/null and b/res/drawable-xxhdpi/ic_social_person.png differ diff --git a/res/layout/user_header.xml b/res/layout/user_header.xml new file mode 100644 index 00000000..5966e0ed --- /dev/null +++ b/res/layout/user_header.xml @@ -0,0 +1,57 @@ + + + + + + + + + + + + + + + + + + diff --git a/res/layout/user_list_item.xml b/res/layout/user_list_item.xml new file mode 100644 index 00000000..40dcf06d --- /dev/null +++ b/res/layout/user_list_item.xml @@ -0,0 +1,45 @@ + + + + + + + + + + + \ No newline at end of file diff --git a/src/github/daneren2005/dsub/fragments/AdminFragment.java b/src/github/daneren2005/dsub/fragments/AdminFragment.java index e0989e43..216ac000 100644 --- a/src/github/daneren2005/dsub/fragments/AdminFragment.java +++ b/src/github/daneren2005/dsub/fragments/AdminFragment.java @@ -91,7 +91,7 @@ public class AdminFragment extends SelectListFragment { @Override public ArrayAdapter getAdapter(List objs) { - return new UserAdapter(context, objs); + return new UserAdapter(context, objs, getImageLoader()); } @Override diff --git a/src/github/daneren2005/dsub/fragments/UserFragment.java b/src/github/daneren2005/dsub/fragments/UserFragment.java index 6423ebcd..fbd672c0 100644 --- a/src/github/daneren2005/dsub/fragments/UserFragment.java +++ b/src/github/daneren2005/dsub/fragments/UserFragment.java @@ -26,6 +26,7 @@ import android.view.MenuInflater; import android.view.MenuItem; import android.view.View; import android.view.ViewGroup; +import android.widget.ImageView; import android.widget.ListView; import android.widget.TextView; @@ -37,6 +38,7 @@ import github.daneren2005.dsub.service.MusicServiceFactory; import github.daneren2005.dsub.service.OfflineException; import github.daneren2005.dsub.service.ServerTooOldException; import github.daneren2005.dsub.util.Constants; +import github.daneren2005.dsub.util.ImageLoader; import github.daneren2005.dsub.util.SilentBackgroundTask; import github.daneren2005.dsub.util.UserUtil; import github.daneren2005.dsub.util.Util; @@ -57,6 +59,7 @@ public class UserFragment extends SubsonicFragment{ user = (User) args.getSerializable(Constants.INTENT_EXTRA_NAME_ID); listView = (ListView)rootView.findViewById(R.id.fragment_list); + createHeader(); listView.setAdapter(new SettingsAdapter(context, user.getSettings(), UserUtil.isCurrentAdmin())); setTitle(user.getUsername()); @@ -104,4 +107,24 @@ public class UserFragment extends SubsonicFragment{ return false; } + + private void createHeader() { + View header = LayoutInflater.from(context).inflate(R.layout.user_header, listView, false); + + final ImageLoader imageLoader = getImageLoader(); + ImageView coverArtView = (ImageView) header.findViewById(R.id.user_avatar); + imageLoader.loadAvatar(context, coverArtView, user.getUsername()); + + TextView usernameView = (TextView) header.findViewById(R.id.user_username); + usernameView.setText(user.getUsername()); + + final TextView emailView = (TextView) header.findViewById(R.id.user_email); + if(user.getEmail() != null) { + emailView.setText(user.getEmail()); + } else { + emailView.setVisibility(View.GONE); + } + + listView.addHeaderView(header); + } } diff --git a/src/github/daneren2005/dsub/service/CachedMusicService.java b/src/github/daneren2005/dsub/service/CachedMusicService.java index 0049e0ac..bd43fbed 100644 --- a/src/github/daneren2005/dsub/service/CachedMusicService.java +++ b/src/github/daneren2005/dsub/service/CachedMusicService.java @@ -577,8 +577,8 @@ public class CachedMusicService implements MusicService { } @Override - public Bitmap getAvatar(String username, Context context, ProgressListener progressListener) throws Exception { - return musicService.getAvatar(username, context, progressListener); + public Bitmap getAvatar(String username, int size, Context context, ProgressListener progressListener) throws Exception { + return musicService.getAvatar(username, size, context, progressListener); } @Override diff --git a/src/github/daneren2005/dsub/service/MusicService.java b/src/github/daneren2005/dsub/service/MusicService.java index dc760f86..cefd0c23 100644 --- a/src/github/daneren2005/dsub/service/MusicService.java +++ b/src/github/daneren2005/dsub/service/MusicService.java @@ -176,7 +176,7 @@ public interface MusicService { void changePassword(String username, String password, Context context, ProgressListener progressListener) throws Exception; - Bitmap getAvatar(String username, Context context, ProgressListener progressListener) throws Exception; + Bitmap getAvatar(String username, int size, Context context, ProgressListener progressListener) throws Exception; int processOfflineSyncs(final Context context, final ProgressListener progressListener) throws Exception; diff --git a/src/github/daneren2005/dsub/service/OfflineMusicService.java b/src/github/daneren2005/dsub/service/OfflineMusicService.java index 75a090c6..a92e41d1 100644 --- a/src/github/daneren2005/dsub/service/OfflineMusicService.java +++ b/src/github/daneren2005/dsub/service/OfflineMusicService.java @@ -726,7 +726,7 @@ public class OfflineMusicService extends RESTMusicService { } @Override - public Bitmap getAvatar(String username, Context context, ProgressListener progressListener) throws Exception { + public Bitmap getAvatar(String username, int size, Context context, ProgressListener progressListener) throws Exception { return null; } diff --git a/src/github/daneren2005/dsub/service/RESTMusicService.java b/src/github/daneren2005/dsub/service/RESTMusicService.java index 371e309c..11431eaa 100644 --- a/src/github/daneren2005/dsub/service/RESTMusicService.java +++ b/src/github/daneren2005/dsub/service/RESTMusicService.java @@ -1284,8 +1284,57 @@ public class RESTMusicService implements MusicService { } @Override - public Bitmap getAvatar(String username, Context context, ProgressListener progressListener) throws Exception { - return null; + public Bitmap getAvatar(String username, int size, Context context, ProgressListener progressListener) throws Exception { + // Return silently if server is too old + if (!Util.checkServerVersion(context, "1.8")) { + return null; + } + + // Synchronize on the username so that we don't download concurrently for + // the same user. + synchronized (username) { + // Use cached file, if existing. + Bitmap bitmap = FileUtil.getAvatarBitmap(context, username, size); + if(bitmap != null) { + return bitmap; + } + + String url = Util.getRestUrl(context, "getAvatar"); + InputStream in = null; + try + { + List parameterNames; + List parameterValues; + + parameterNames = Collections.singletonList("username"); + parameterValues = Arrays.asList(username); + + HttpEntity entity = getEntityForURL(context, url, null, parameterNames, parameterValues, progressListener); + in = entity.getContent(); + + // If content type is XML, an error occurred. Get it. + String contentType = Util.getContentType(entity); + if (contentType != null && contentType.startsWith("text/xml")) + { + new ErrorParser(context).parse(new InputStreamReader(in, Constants.UTF_8)); + return null; // Never reached. + } + + byte[] bytes = Util.toByteArray(in); + OutputStream out = null; + try { + out = new FileOutputStream(FileUtil.getAvatarFile(context, username)); + out.write(bytes); + } finally { + Util.close(out); + } + + return FileUtil.getSampledBitmap(bytes, size); + } + finally { + Util.close(in); + } + } } @Override diff --git a/src/github/daneren2005/dsub/util/FileUtil.java b/src/github/daneren2005/dsub/util/FileUtil.java index a68ded45..e84f6eb2 100644 --- a/src/github/daneren2005/dsub/util/FileUtil.java +++ b/src/github/daneren2005/dsub/util/FileUtil.java @@ -200,6 +200,34 @@ public class FileUtil { } return null; } + + public static File getAvatarDirectory(Context context) { + File avatarDir = new File(getSubsonicDirectory(context), "avatars"); + ensureDirectoryExistsAndIsReadWritable(avatarDir); + ensureDirectoryExistsAndIsReadWritable(new File(avatarDir, ".nomedia")); + return avatarDir; + } + + public static File getAvatarFile(Context context, String username) { + return new File(getAvatarDirectory(context), Util.md5Hex(username) + ".jpeg"); + } + + public static Bitmap getAvatarBitmap(Context context, String username, int size) { + File avatarFile = getAvatarFile(context, username); + if (avatarFile.exists()) { + final BitmapFactory.Options opt = new BitmapFactory.Options(); + opt.inJustDecodeBounds = true; + BitmapFactory.decodeFile(avatarFile.getPath(), opt); + opt.inPurgeable = true; + opt.inSampleSize = Util.calculateInSampleSize(opt, size, Util.getScaledHeight(opt.outHeight, opt.outWidth, size)); + opt.inJustDecodeBounds = false; + + Bitmap bitmap = BitmapFactory.decodeFile(avatarFile.getPath(), opt); + return bitmap == null ? null : getScaledBitmap(bitmap, size); + } + return null; + } + public static Bitmap getSampledBitmap(byte[] bytes, int size) { final BitmapFactory.Options opt = new BitmapFactory.Options(); opt.inJustDecodeBounds = true; diff --git a/src/github/daneren2005/dsub/util/ImageLoader.java b/src/github/daneren2005/dsub/util/ImageLoader.java index b1b00cc5..f9c5fed5 100644 --- a/src/github/daneren2005/dsub/util/ImageLoader.java +++ b/src/github/daneren2005/dsub/util/ImageLoader.java @@ -18,7 +18,6 @@ */ package github.daneren2005.dsub.util; -import android.annotation.TargetApi; import android.content.Context; import android.graphics.Bitmap; import android.graphics.drawable.BitmapDrawable; @@ -26,7 +25,6 @@ import android.graphics.drawable.Drawable; import android.graphics.drawable.TransitionDrawable; import android.media.RemoteControlClient; import android.os.Build; -import android.os.Handler; import android.util.DisplayMetrics; import android.util.Log; import android.support.v4.util.LruCache; @@ -38,9 +36,6 @@ import github.daneren2005.dsub.domain.MusicDirectory; import github.daneren2005.dsub.service.MusicService; import github.daneren2005.dsub.service.MusicServiceFactory; -import java.util.concurrent.BlockingQueue; -import java.util.concurrent.LinkedBlockingQueue; - /** * Asynchronous loading of images, with caching. *

@@ -56,6 +51,7 @@ public class ImageLoader { private Bitmap nowPlaying; private final int imageSizeDefault; private final int imageSizeLarge; + private final int avatarSizeDefault; private Drawable largeUnknownImage; public ImageLoader(Context context) { @@ -86,6 +82,7 @@ public class ImageLoader { imageSizeDefault = context.getResources().getDrawable(R.drawable.unknown_album).getIntrinsicHeight(); DisplayMetrics metrics = context.getResources().getDisplayMetrics(); imageSizeLarge = Math.round(Math.min(metrics.widthPixels, metrics.heightPixels)); + avatarSizeDefault = context.getResources().getDrawable(R.drawable.ic_social_person).getIntrinsicHeight(); createLargeUnknownImage(context); } @@ -173,6 +170,17 @@ public class ImageLoader { new RemoteControlClientImageTask(context, entry, imageSizeLarge, imageSizeLarge, false, remoteControl).execute(); } + public void loadAvatar(Context context, ImageView view, String username) { + Bitmap bitmap = cache.get(username); + if (bitmap != null && !bitmap.isRecycled()) { + Drawable drawable = Util.createDrawableFromBitmap(this.context, bitmap); + view.setImageDrawable(drawable); + return; + } + + new AvatarTask(context, view, username).execute(); + } + private String getKey(String coverArtId, int size) { return coverArtId + size; } @@ -322,4 +330,45 @@ public class ImageLoader { setImage(mRemoteControl, mDrawable); } } + + private class AvatarTask extends SilentBackgroundTask { + private final Context mContext; + private final String mUsername; + private final ImageView mView; + private Drawable mDrawable; + + public AvatarTask(Context context, ImageView view, String username) { + super(context); + mContext = context; + mView = view; + mUsername = username; + } + + @Override + protected Void doInBackground() throws Throwable { + try { + MusicService musicService = MusicServiceFactory.getMusicService(mContext); + Bitmap bitmap = musicService.getAvatar(mUsername, avatarSizeDefault, mContext, null); + if(bitmap != null) { + cache.put(mUsername, bitmap); + // Make sure key is the most recently "used" + cache.get(mUsername); + + mDrawable = Util.createDrawableFromBitmap(mContext, bitmap); + } + } catch (Throwable x) { + Log.e(TAG, "Failed to download album art.", x); + cancelled = true; + } + + return null; + } + + @Override + protected void done(Void result) { + if(mDrawable != null) { + mView.setImageDrawable(mDrawable); + } + } + } } diff --git a/src/github/daneren2005/dsub/view/UserAdapter.java b/src/github/daneren2005/dsub/view/UserAdapter.java index 937e2e92..70a1748a 100644 --- a/src/github/daneren2005/dsub/view/UserAdapter.java +++ b/src/github/daneren2005/dsub/view/UserAdapter.java @@ -24,13 +24,16 @@ import java.util.List; import github.daneren2005.dsub.R; import github.daneren2005.dsub.domain.User; +import github.daneren2005.dsub.util.ImageLoader; public class UserAdapter extends ArrayAdapter { private final Context activity; + private final ImageLoader imageLoader; - public UserAdapter(Context activity, List users) { + public UserAdapter(Context activity, List users, ImageLoader imageLoader) { super(activity, R.layout.basic_list_item, users); this.activity = activity; + this.imageLoader = imageLoader; } @Override @@ -42,7 +45,7 @@ public class UserAdapter extends ArrayAdapter { } else { view = new UserView(activity); } - view.setObject(entry); + view.setObject(entry, imageLoader); return view; } } \ No newline at end of file diff --git a/src/github/daneren2005/dsub/view/UserView.java b/src/github/daneren2005/dsub/view/UserView.java index f966f28f..31e02d99 100644 --- a/src/github/daneren2005/dsub/view/UserView.java +++ b/src/github/daneren2005/dsub/view/UserView.java @@ -23,18 +23,21 @@ import android.widget.TextView; import github.daneren2005.dsub.R; import github.daneren2005.dsub.domain.User; +import github.daneren2005.dsub.util.ImageLoader; public class UserView extends UpdateView { private User user; - private TextView userNameView; + private TextView usernameView; + private ImageView avatarView; public UserView(Context context) { super(context); this.context = context; - LayoutInflater.from(context).inflate(R.layout.basic_list_item, this, true); + LayoutInflater.from(context).inflate(R.layout.user_list_item, this, true); - userNameView = (TextView) findViewById(R.id.item_name); + usernameView = (TextView) findViewById(R.id.item_name); + avatarView = (ImageView) findViewById(R.id.item_avatar); moreButton = (ImageView) findViewById(R.id.item_more); moreButton.setOnClickListener(new View.OnClickListener() { public void onClick(View v) { @@ -43,8 +46,9 @@ public class UserView extends UpdateView { }); } - protected void setObjectImpl(Object obj) { + protected void setObjectImpl(Object obj, Object obj2) { this.user = (User) obj; - userNameView.setText(user.getUsername()); + usernameView.setText(user.getUsername()); + ((ImageLoader)obj2).loadAvatar(context, avatarView, user.getUsername()); } } -- cgit v1.2.3