blob: e91fdefd8a821dc42f2c56a2a55634ba335f5ce9 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
|
From 81033c66738a2e3b713c414e8e07e6ef8e59d8d7 Mon Sep 17 00:00:00 2001
From: Luke Shumaker <lukeshu@parabola.nu>
Date: Thu, 28 Dec 2017 07:22:29 -0500
Subject: [PATCH 09/10] linux-user: init_guest_space: Add a comment about
search strategy
Signed-off-by: Luke Shumaker <lukeshu@parabola.nu>
---
linux-user/elfload.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 1b7583d659..7736ea2c3a 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -1936,6 +1936,10 @@ unsigned long init_guest_space(unsigned long host_start,
* happen often. Probably means we got unlucky and host
* address space randomization put a shared library somewhere
* inconvenient.
+ *
+ * This is probably a good strategy if host_start, but is
+ * probably a bad strategy if not, which means we got here
+ * because of trouble with ARM commpage setup.
*/
munmap((void *)real_start, real_size);
current_start += qemu_host_page_size;
--
2.15.1
|
