From 19687d63663f0de35f80e5492e040cf5569e1714 Mon Sep 17 00:00:00 2001 From: Omar Vega Ramos Date: Sun, 22 Oct 2017 13:31:50 -0500 Subject: java-runtime-common-3-1.parabola1: updating version --- libre/java-common/PKGBUILD | 21 +-- libre/java-common/bin_parabola-java | 20 ++- libre/java-common/test_parabola-java | 299 ++++++++++++++++++++++++++++------- 3 files changed, 264 insertions(+), 76 deletions(-) (limited to 'libre') diff --git a/libre/java-common/PKGBUILD b/libre/java-common/PKGBUILD index 0a9cbe958..ffc988808 100644 --- a/libre/java-common/PKGBUILD +++ b/libre/java-common/PKGBUILD @@ -1,14 +1,16 @@ # Maintainer (Arch): Guillaume ALAUX -# Maintainer: André Silva +# Maintainer (Hyperbola): André Silva +# Maintainer: Omar Vega Ramos pkgname=java-runtime-common pkgbase=java-common -pkgver=2 -pkgrel=2.parabola2 +pkgver=3 +pkgrel=1.parabola1 pkgdesc='Common files for Java Runtime Environments (Parabola rebranded)' arch=('any') -url='www.parabola.nu' +url='https://www.parabola.nu/packages/libre/any/java-runtime-common/' license=('GPL') checkdepends=('wget') +_shunitver=2.1.6 conflicts=('java-common') replaces=('java-common') backup=(etc/profile.d/jre.sh @@ -18,16 +20,17 @@ source=(profile_jre.csh profile_jre.sh bin_parabola-java test_parabola-java - https://shunit2.googlecode.com/files/shunit2-2.1.6.tgz) + shunit2-${_shunitver}.tar.gz::https://github.com/kward/shunit2/archive/source.tar.gz) sha256sums=('fb981764fbdcb33976085405d002a1427b5401da5f13f1dd00008dbe8306583a' '36e07f9387f24ff0c6dff1b4c6d9011eedef4bd22634e0c5a6335817991dc151' - '103e0cbd0dd3b11376ba61e743f481f1a720c336f7b67d09a6b189f988e2fe6e' - '6e0f4173d4cfaad5ab0ed953fad770ee70b355349304c3bd34043edf0b6a7ab5' - '65a313a76fd5cc1c58c9e19fbc80fc0e418a4cbfbd46d54b35ed5b6e0025d4ee') + 'b5d2bbbad708a84d4f2674dcba9053d777c735130843f6f924f063f456f2601d' + 'aab03dee5a3567c12d1af30374486aeaa6e317404ecf018dcb675124225f5853' + '6beca93d20b72b46083c8271c4cf1da21b45f250a92b401c2565c65e1d75138f') check() { cd "${srcdir}" + ln -s shunit2-source/${_shunitver} shunit2 ./test_parabola-java } @@ -47,7 +50,7 @@ package() { # Official list of binaries that Java headless runtime packages MUST provide # This list is based on Parabola' default Java implementation: "OpenJDK 7 Icedtea" for b in \ - java keytool orbd pack200 policytool rmid rmiregistry servertool tnameserv unpack200; + java keytool orbd pack200 rmid rmiregistry servertool tnameserv unpack200; do ln -s /usr/lib/jvm/default-runtime/bin/${b} "${pkgdir}/usr/bin/${b}" done diff --git a/libre/java-common/bin_parabola-java b/libre/java-common/bin_parabola-java index 47f410096..7039f0f8f 100755 --- a/libre/java-common/bin_parabola-java +++ b/libre/java-common/bin_parabola-java @@ -45,7 +45,7 @@ get_default_java() { get_installed_javas() { if [ -d ${JVM_DIR} ]; then for dir in $(find ${JVM_DIR} -mindepth 1 -maxdepth 1 -type d | sort); do - if [ -x ${dir}/bin/javac ]; then + if [ -x ${dir}/bin/java ]; then javas+=(${dir/${JVM_DIR}\/}) else if [ -x ${dir}/jre/bin/java ]; then @@ -69,10 +69,10 @@ set_default_link_to() { ln -sf ${new_default} ${DEFAULT_PATH} unlink ${DEFAULT_PATH_JRE} 2>/dev/null - if [[ ${new_default} == */jre ]]; then - ln -sf ${new_default} ${DEFAULT_PATH_JRE} - else + if [[ -d ${new_default}/jre ]]; then ln -sf ${new_default}/jre ${DEFAULT_PATH_JRE} + else + ln -sf ${new_default} ${DEFAULT_PATH_JRE} fi } @@ -91,6 +91,7 @@ do_status() { default_java=$(get_default_java) echo 'Available Java environments:' for java in ${installed_java[@]}; do + # We discoverd this Java env but its JRE is actually set as default if [ "${java}/jre" = "${default_java}" ]; then echo -e " ${java} (${java}/jre default)" elif [ ${java} = "${default_java}" ]; then @@ -136,6 +137,7 @@ do_unset() { do_fix() { default=$(get_default_java) if is_java_valid ${default}; then + # If its parent is also a valid Java environment if is_java_valid $(dirname ${default}); then unset_default_link set_default_link_to $(dirname ${default}) @@ -143,9 +145,13 @@ do_fix() { else prev=$(readlink ${DEFAULT_PATH}) unset_default_link - prev_fix=("${prev/\/jre}" "${prev}/jre") - openjdk7=('java-7-openjdk' 'java-7-openjdk/jre') - to_check=(${prev_fix[@]} ${openjdk7[@]} $(get_installed_javas)) + potential_fixes=("${prev/\/jre}" "${prev}/jre") + openjdk8=('java-8-openjdk' 'java-8-openjdk/jre') + # List of environments to check by order of preference: + # - first potential fixes of user choices, + # - then OpenJDK8 as it is considered a default in Parabola + # - finally, any installed environment + to_check=(${potential_fixes[@]} ${openjdk8[@]} $(get_installed_javas)) for java in ${to_check[@]}; do if ! is_java_valid $(get_default_java) && is_java_valid ${java}; then set_default_link_to ${java} diff --git a/libre/java-common/test_parabola-java b/libre/java-common/test_parabola-java index 89b57655a..1fff993b5 100755 --- a/libre/java-common/test_parabola-java +++ b/libre/java-common/test_parabola-java @@ -1,6 +1,6 @@ #! /bin/sh # -# To run this script, ensure shunit2 (https://code.google.com/p/shunit2/) +# To run this script, ensure shunit2 (https://github.com/kward/shunit2) # is available on the local directory, then just run sh bin_parabola-java_tests # # inotifywait -r -m -e MODIFY . | while read l; do sh bin_parabola-java_tests; done @@ -37,22 +37,32 @@ tearDown() { } # $1: path of Java environment to create -create_valid_jre_env() { - mkdir -p ${JVM_DIR}/$1/bin - for binary in java keytool orbd; do - touch ${JVM_DIR}/$1/bin/${binary} - chmod +x ${JVM_DIR}/$1/bin/${binary} - done +create_raw_java_env() { + java_env_name=$1 + bin_name=$2 + mkdir -p ${JVM_DIR}/${java_env_name}/bin + touch ${JVM_DIR}/${java_env_name}/bin/$bin_name + chmod +x ${JVM_DIR}/${java_env_name}/bin/$bin_name +} + +create_valid_jre8_env() { + create_raw_java_env "$1/jre" "java" } # $1: path of Java environment to create -create_valid_jdk_env() { - create_valid_jre_env "$1" - for binary in javac javah jhat; do - touch ${JVM_DIR}/$1/bin/${binary} - chmod +x ${JVM_DIR}/$1/bin/${binary} - done - create_valid_jre_env "$1/jre" +create_valid_jre8_jdk8_env() { + create_raw_java_env "$1" "java" + create_raw_java_env "$1" "javac" + create_valid_jre8_env "$1" +} + +create_valid_jre9_env() { + create_raw_java_env "$1" "java" +} + +create_valid_jre9_jdk9_env() { + create_raw_java_env "$1" "java" + create_raw_java_env "$1" "javac" } set_default_for_test() { @@ -79,24 +89,78 @@ assertDefaultSetTo() { # do_status -test_do_status() { +test_do_status_with_jre8_default() { JAVA_NAME_1="a$(get_rand_str)" JAVA_NAME_2="b$(get_rand_str)" - create_valid_jre_env "${JAVA_NAME_1}/jre" + JAVA_NAME_3="c$(get_rand_str)" + create_valid_jre8_env "${JAVA_NAME_1}" set_default_for_test "${JAVA_NAME_1}/jre" - create_valid_jdk_env "${JAVA_NAME_2}" - expected=$(echo -e "Available Java environments:\n ${JAVA_NAME_1}/jre (default)\n ${JAVA_NAME_2}") + create_valid_jre8_jdk8_env "${JAVA_NAME_2}" + create_valid_jre9_env "${JAVA_NAME_3}" + mess="Available Java environments:" + mess+="\n ${JAVA_NAME_1}/jre (default)" + mess+="\n ${JAVA_NAME_2}" + mess+="\n ${JAVA_NAME_3}" + expected=$(echo -e "${mess}") + assertEquals 'Wrong status output' "${expected}" "$(do_status)" +} + +test_do_status_with_jre9_default() { + JAVA_NAME_1="a$(get_rand_str)" + JAVA_NAME_2="b$(get_rand_str)" + JAVA_NAME_3="c$(get_rand_str)" + create_valid_jre8_env "${JAVA_NAME_1}" + create_valid_jre8_jdk8_env "${JAVA_NAME_2}" + create_valid_jre9_env "${JAVA_NAME_3}" + set_default_for_test "${JAVA_NAME_3}" + mess="Available Java environments:" + mess+="\n ${JAVA_NAME_1}/jre" + mess+="\n ${JAVA_NAME_2}" + mess+="\n ${JAVA_NAME_3} (default)" + expected=$(echo -e "${mess}") + assertEquals 'Wrong status output' "${expected}" "$(do_status)" +} + +test_do_status_with_jdk9_default() { + JAVA_NAME_1="a$(get_rand_str)" + JAVA_NAME_2="b$(get_rand_str)" + JAVA_NAME_3="c$(get_rand_str)" + create_valid_jre8_env "${JAVA_NAME_1}" + create_valid_jre8_jdk8_env "${JAVA_NAME_2}" + create_valid_jre9_jdk9_env "${JAVA_NAME_3}" + set_default_for_test "${JAVA_NAME_3}" + mess="Available Java environments:" + mess+="\n ${JAVA_NAME_1}/jre" + mess+="\n ${JAVA_NAME_2}" + mess+="\n ${JAVA_NAME_3} (default)" + expected=$(echo -e "${mess}") assertEquals 'Wrong status output' "${expected}" "$(do_status)" } test_do_status_no_default() { JAVA_NAME_1="a$(get_rand_str)" JAVA_NAME_2="b$(get_rand_str)" - create_valid_jre_env "${JAVA_NAME_1}/jre" - create_valid_jdk_env "${JAVA_NAME_2}" + JAVA_NAME_3="c$(get_rand_str)" + JAVA_NAME_4="d$(get_rand_str)" + create_valid_jre8_env "${JAVA_NAME_1}" + create_valid_jre8_jdk8_env "${JAVA_NAME_2}" + create_valid_jre9_env "${JAVA_NAME_3}" + create_valid_jre9_jdk9_env "${JAVA_NAME_4}" mess="Available Java environments:" mess+="\n ${JAVA_NAME_1}/jre" mess+="\n ${JAVA_NAME_2}" + mess+="\n ${JAVA_NAME_3}" + mess+="\n ${JAVA_NAME_4}" + mess+="\nNo Java environment set as default" + expected=$(echo -e "${mess}") + assertEquals 'Wrong status output' "${expected}" "$(do_status)" +} + +test_do_status_no_duplicate_entry_jre9_jdk9() { + JAVA_NAME_1="a$(get_rand_str)" + create_valid_jre9_jdk9_env "${JAVA_NAME_1}" + mess="Available Java environments:" + mess+="\n ${JAVA_NAME_1}" mess+="\nNo Java environment set as default" expected=$(echo -e "${mess}") assertEquals 'Wrong status output' "${expected}" "$(do_status)" @@ -107,7 +171,7 @@ test_do_status_no_javas() { } test_do_status_jre_but_jdk_exists() { - create_valid_jdk_env "${JAVA_NAME}" + create_valid_jre8_jdk8_env "${JAVA_NAME}" set_default_for_test "${JAVA_NAME}/jre" mess="Available Java environments:" mess+="\n ${JAVA_NAME} (${JAVA_NAME}/jre default)" @@ -117,27 +181,35 @@ test_do_status_jre_but_jdk_exists() { # do_get -test_do_get_with_default() { - create_valid_jdk_env "${JAVA_NAME}" +test_do_get_with_jdk8_default() { + create_valid_jre8_jdk8_env "${JAVA_NAME}" set_default_for_test "${JAVA_NAME}" assertEquals 'Wrong result' "${JAVA_NAME}" "$(do_get)" assertDefaultSetTo "${JAVA_NAME}" } test_do_get_without_default() { - create_valid_jdk_env "${JAVA_NAME}" + create_valid_jre8_jdk8_env "$(get_rand_str)" + create_valid_jre9_jdk9_env "$(get_rand_str)" assertNull 'Wrong result' "$(do_get)" } -test_do_get_without_default() { +test_do_get_with_initial_null() { set_default_for_test "/dev/null" assertNull 'Wrong result' "$(do_get)" } +test_do_get_with_jdk9_default() { + create_valid_jre9_jdk9_env "${JAVA_NAME}" + set_default_for_test "${JAVA_NAME}" + assertEquals 'Wrong result' "${JAVA_NAME}" "$(do_get)" + assertDefaultSetTo "${JAVA_NAME}" +} + # do_set test_do_set_new_invalid() { - create_valid_jdk_env "${JAVA_NAME}" + create_valid_jre8_jdk8_env "${JAVA_NAME}" set_default_for_test "${JAVA_NAME}" output=$(do_set "INVALID") assertEquals 'Wrong status returned' 1 $? @@ -146,32 +218,66 @@ test_do_set_new_invalid() { } test_do_set_current_invalid() { - create_valid_jdk_env "${JAVA_NAME}" + create_valid_jre8_jdk8_env "${JAVA_NAME}" set_default_for_test "INVALID" $(do_set "${JAVA_NAME}") assertEquals 'Wrong status returned' 0 $? assertDefaultSetTo "${JAVA_NAME}" } -test_do_set_with_default_already_set() { - create_valid_jre_env "${JAVA_NAME}/jre" +test_do_set_jre8_with_default_already_set_to_jre8() { + create_valid_jre8_env "${JAVA_NAME}" set_default_for_test "${JAVA_NAME}/jre" JAVA_NAME_2="$(get_rand_str)" - create_valid_jre_env "${JAVA_NAME_2}/jre" + create_valid_jre8_env "${JAVA_NAME_2}" $(do_set "${JAVA_NAME_2}/jre") assertEquals 'Wrong status returned' 0 $? assertDefaultSetTo "${JAVA_NAME_2}/jre" } -test_do_set_no_default() { - create_valid_jre_env "${JAVA_NAME}/jre" +test_do_set_jre9_with_default_already_set_to_jre8() { + create_valid_jre8_env "${JAVA_NAME}" + set_default_for_test "${JAVA_NAME}/jre" + JAVA_NAME_2="$(get_rand_str)" + create_valid_jre9_env "${JAVA_NAME_2}" + $(do_set "${JAVA_NAME_2}") + assertEquals 'Wrong status returned' 0 $? + assertDefaultSetTo "${JAVA_NAME_2}" +} + +test_do_set_jdk9_with_default_already_set_to_jdk8() { + create_valid_jre8_jdk8_env "${JAVA_NAME}" + set_default_for_test "${JAVA_NAME}" + JAVA_NAME_2="$(get_rand_str)" + create_valid_jre9_jdk9_env "${JAVA_NAME_2}" + $(do_set "${JAVA_NAME_2}") + assertEquals 'Wrong status returned' 0 $? + assertDefaultSetTo "${JAVA_NAME_2}" +} + +test_do_set_jre8_no_previous_default() { + create_valid_jre8_env "${JAVA_NAME}" $(do_set "${JAVA_NAME}/jre") assertEquals 'Wrong status returned' 0 $? assertDefaultSetTo "${JAVA_NAME}/jre" } -test_do_set_exists_jdk() { - create_valid_jdk_env "${JAVA_NAME}" +test_do_set_jre9_no_previous_default() { + create_valid_jre9_env "${JAVA_NAME}" + $(do_set "${JAVA_NAME}") + assertEquals 'Wrong status returned' 0 $? + assertDefaultSetTo "${JAVA_NAME}" +} + +test_do_set_jdk9_no_previous_default() { + create_valid_jre9_jdk9_env "${JAVA_NAME}" + $(do_set "${JAVA_NAME}") + assertEquals 'Wrong status returned' 0 $? + assertDefaultSetTo "${JAVA_NAME}" +} + +test_do_set_jre8_while_jdk8_also_exists() { + create_valid_jre8_jdk8_env "${JAVA_NAME}" output=$(do_set "${JAVA_NAME}/jre") assertEquals 'Wrong status returned' 0 $? assertDefaultSetTo "${JAVA_NAME}/jre" @@ -181,33 +287,52 @@ test_do_set_exists_jdk() { #assertEquals 'Wrong message' "${expected}" "${output}" } -test_do_set_cleanup_old_java_default() { - create_valid_jdk_env "${JAVA_NAME}" +test_do_set_jdk8_cleanup_old_jre8_default() { + create_valid_jre8_jdk8_env "${JAVA_NAME}" set_default_for_test "${JAVA_NAME}" output=$(do_set "${JAVA_NAME}/jre") assertEquals 'Wrong status returned' 0 $? assertDefaultSetTo "${JAVA_NAME}/jre" } -test_do_set_devnull() { - create_valid_jdk_env "${JAVA_NAME}" +test_do_set_jdk9_cleanup_old_jdk8_default() { + JAVA8_NAME=$(get_rand_str) + create_valid_jre8_jdk8_env "${JAVA8_NAME}" + set_default_for_test "${JAVA8_NAME}" + JAVA9_NAME=$(get_rand_str) + create_valid_jre9_jdk9_env "${JAVA9_NAME}" + output=$(do_set "${JAVA9_NAME}") + assertEquals 'Wrong status returned' 0 $? + assertDefaultSetTo "${JAVA9_NAME}" +} + +test_do_set_jdk8_devnull() { + create_valid_jre8_jdk8_env "${JAVA_NAME}" set_default_for_test "/dev/null" output=$(do_set "${JAVA_NAME}/jre") assertEquals 'Wrong status returned' 0 $? assertDefaultSetTo "${JAVA_NAME}/jre" } +test_do_set_jdk9_devnull() { + create_valid_jre9_jdk9_env "${JAVA_NAME}" + set_default_for_test "/dev/null" + output=$(do_set "${JAVA_NAME}") + assertEquals 'Wrong status returned' 0 $? + assertDefaultSetTo "${JAVA_NAME}" +} + # do_unset -test_do_unset_default_not_target() { - create_valid_jre_env "${JAVA_NAME}/jre" +test_do_unset_jre8() { + create_valid_jre8_env "${JAVA_NAME}" set_default_for_test "${JAVA_NAME}/jre" do_unset assertDefaultNotSet } test_do_unset_no_default_link() { - create_valid_jdk_env "${JAVA_NAME}" + create_valid_jre8_jdk8_env "${JAVA_NAME}" set_default_for_test "${JAVA_NAME}" unlink ${DEFAULT_PATH} do_unset @@ -220,37 +345,90 @@ test_do_unset_devnull() { assertDefaultNotSet } +test_do_unset_jre9() { + create_valid_jre9_env "${JAVA_NAME}" + set_default_for_test "${JAVA_NAME}" + do_unset + assertDefaultNotSet +} + +test_do_unset_jdk9() { + create_valid_jre9_jdk9_env "${JAVA_NAME}" + set_default_for_test "${JAVA_NAME}" + do_unset + assertDefaultNotSet +} + # do_fix -test_do_fix_default_valid() { - create_valid_jre_env "${JAVA_NAME}/jre" +test_do_fix_default_valid_jre8() { + create_valid_jre8_env "${JAVA_NAME}" set_default_for_test "${JAVA_NAME}/jre" do_fix assertDefaultSetTo "${JAVA_NAME}/jre" } -test_do_fix_no_default() { - create_valid_jre_env "${JAVA_NAME}/jre" +test_do_fix_default_valid_jre9() { + create_valid_jre9_env "${JAVA_NAME}" + set_default_for_test "${JAVA_NAME}" + do_fix + assertDefaultSetTo "${JAVA_NAME}" +} + +test_do_fix_default_valid_jdk9() { + create_valid_jre9_jdk9_env "${JAVA_NAME}" + set_default_for_test "${JAVA_NAME}" + do_fix + assertDefaultSetTo "${JAVA_NAME}" +} + +test_do_fix_no_default_jre8() { + create_valid_jre8_env "${JAVA_NAME}" do_fix assertDefaultSetTo "${JAVA_NAME}/jre" } +test_do_fix_no_default_jre9() { + create_valid_jre9_env "${JAVA_NAME}" + do_fix + assertDefaultSetTo "${JAVA_NAME}" +} + +test_do_fix_no_default_jdk9() { + create_valid_jre9_jdk9_env "${JAVA_NAME}" + do_fix + assertDefaultSetTo "${JAVA_NAME}" +} + test_do_fix_default_invalid_openjdk7_jdk_installed() { - create_valid_jdk_env "java-7-openjdk" - create_valid_jdk_env "${JAVA_NAME}" + create_valid_jre8_jdk8_env "java-8-openjdk" + create_valid_jre8_jdk8_env "${JAVA_NAME}" + do_fix + assertDefaultSetTo "java-8-openjdk" +} + +test_do_fix_jdk8_not_default_but_openjdk7_jre_installed() { + create_valid_jre8_jdk8_env "${JAVA_NAME}" + create_valid_jre8_env "java-8-openjdk" + do_fix + assertDefaultSetTo "java-8-openjdk/jre" +} + +test_do_fix_jdk9_not_default_but_openjdk7_jre_installed() { + create_valid_jre9_jdk9_env "${JAVA_NAME}" + create_valid_jre8_env "java-8-openjdk" do_fix - assertDefaultSetTo "java-7-openjdk" + assertDefaultSetTo "java-8-openjdk/jre" } -test_do_fix_default_invalid_openjdk7_jre_installed() { - create_valid_jdk_env "${JAVA_NAME}" - create_valid_jre_env "java-7-openjdk/jre" +test_do_fix_default_invalid_random_java8_installed() { + create_valid_jre8_jdk8_env "${JAVA_NAME}" do_fix - assertDefaultSetTo "java-7-openjdk/jre" + assertDefaultSetTo "${JAVA_NAME}" } -test_do_fix_default_invalid_random_java_installed() { - create_valid_jdk_env "${JAVA_NAME}" +test_do_fix_default_invalid_random_java9_installed() { + create_valid_jre9_jdk9_env "${JAVA_NAME}" do_fix assertDefaultSetTo "${JAVA_NAME}" } @@ -260,27 +438,28 @@ test_do_fix_default_invalid_no_java_installed() { assertDefaultNotSet } -test_do_fix_jre_but_jdk_exists() { - create_valid_jdk_env "${JAVA_NAME}" +test_do_fix_jre8_but_jdk8_exists() { + create_valid_jre8_jdk8_env "${JAVA_NAME}" set_default_for_test "${JAVA_NAME}/jre" do_fix assertDefaultSetTo "${JAVA_NAME}" } test_do_fix_jdk_but_jre_exists() { - create_valid_jdk_env "java-7-openjdk" - create_valid_jre_env "${JAVA_NAME}/jre" + create_valid_jre8_jdk8_env "java-7-openjdk" + create_valid_jre8_env "${JAVA_NAME}" + # Only JRE is installed but setting JDK as default set_default_for_test "${JAVA_NAME}" do_fix assertDefaultSetTo "${JAVA_NAME}/jre" } test_do_fix_devnull() { - create_valid_jdk_env "${JAVA_NAME}" + create_valid_jre8_jdk8_env "${JAVA_NAME}" set_default_for_test "/dev/null" do_fix assertDefaultSetTo "${JAVA_NAME}" } # load shunit2 -. shunit2-2.1.6/src/shunit2 +. shunit2/src/shunit2 -- cgit v1.2.3