summaryrefslogtreecommitdiff
path: root/libre/uboot-chiliboard/0004-common-board_f-cosmetic-use-__weak-for-leds.patch
diff options
context:
space:
mode:
authorAndré Fabian Silva Delgado <emulatorman@parabola.nu>2016-03-02 03:57:21 -0300
committerAndré Fabian Silva Delgado <emulatorman@parabola.nu>2016-03-02 03:57:21 -0300
commit3d328e4bfc34a90c8ce14bcaee1120c5840dd925 (patch)
tree3fdbaa64ce890c34591b8d2723e523b85d88f7d7 /libre/uboot-chiliboard/0004-common-board_f-cosmetic-use-__weak-for-leds.patch
parentb32b93d29dd6eeabc87cb9938c66c2139604f867 (diff)
downloadabslibre-3d328e4bfc34a90c8ce14bcaee1120c5840dd925.tar.gz
abslibre-3d328e4bfc34a90c8ce14bcaee1120c5840dd925.tar.bz2
abslibre-3d328e4bfc34a90c8ce14bcaee1120c5840dd925.zip
uboot-chiliboard: add new package to [libre]
Diffstat (limited to 'libre/uboot-chiliboard/0004-common-board_f-cosmetic-use-__weak-for-leds.patch')
-rw-r--r--libre/uboot-chiliboard/0004-common-board_f-cosmetic-use-__weak-for-leds.patch109
1 files changed, 109 insertions, 0 deletions
diff --git a/libre/uboot-chiliboard/0004-common-board_f-cosmetic-use-__weak-for-leds.patch b/libre/uboot-chiliboard/0004-common-board_f-cosmetic-use-__weak-for-leds.patch
new file mode 100644
index 000000000..f2237a229
--- /dev/null
+++ b/libre/uboot-chiliboard/0004-common-board_f-cosmetic-use-__weak-for-leds.patch
@@ -0,0 +1,109 @@
+From ea9b2d003712ae2c6158abb5c9f285f593e8fcb0 Mon Sep 17 00:00:00 2001
+From: Jeroen Hofstee <jeroen@myspectrum.nl>
+Date: Mon, 23 Jun 2014 23:20:19 +0200
+Subject: [PATCH 4/6] common: board_f: cosmetic use __weak for leds
+
+First of all this looks a lot better, but it also
+prevents a gcc warning (W=1), that the weak function
+has no previous prototype.
+
+cc: Simon Glass <sjg@chromium.org>
+Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
+Acked-by: Simon Glass <sjg@chromium.org>
+---
+ common/board_f.c | 29 ++++++++++-------------------
+ include/status_led.h | 22 +++++++++++-----------
+ 2 files changed, 21 insertions(+), 30 deletions(-)
+
+diff --git a/common/board_f.c b/common/board_f.c
+index 4ea4cb2..bdab38e 100644
+--- a/common/board_f.c
++++ b/common/board_f.c
+@@ -37,6 +37,7 @@
+ #include <os.h>
+ #include <post.h>
+ #include <spi.h>
++#include <status_led.h>
+ #include <trace.h>
+ #include <watchdog.h>
+ #include <asm/errno.h>
+@@ -78,25 +79,15 @@ DECLARE_GLOBAL_DATA_PTR;
+ ************************************************************************
+ * May be supplied by boards if desired
+ */
+-inline void __coloured_LED_init(void) {}
+-void coloured_LED_init(void)
+- __attribute__((weak, alias("__coloured_LED_init")));
+-inline void __red_led_on(void) {}
+-void red_led_on(void) __attribute__((weak, alias("__red_led_on")));
+-inline void __red_led_off(void) {}
+-void red_led_off(void) __attribute__((weak, alias("__red_led_off")));
+-inline void __green_led_on(void) {}
+-void green_led_on(void) __attribute__((weak, alias("__green_led_on")));
+-inline void __green_led_off(void) {}
+-void green_led_off(void) __attribute__((weak, alias("__green_led_off")));
+-inline void __yellow_led_on(void) {}
+-void yellow_led_on(void) __attribute__((weak, alias("__yellow_led_on")));
+-inline void __yellow_led_off(void) {}
+-void yellow_led_off(void) __attribute__((weak, alias("__yellow_led_off")));
+-inline void __blue_led_on(void) {}
+-void blue_led_on(void) __attribute__((weak, alias("__blue_led_on")));
+-inline void __blue_led_off(void) {}
+-void blue_led_off(void) __attribute__((weak, alias("__blue_led_off")));
++__weak void coloured_LED_init(void) {}
++__weak void red_led_on(void) {}
++__weak void red_led_off(void) {}
++__weak void green_led_on(void) {}
++__weak void green_led_off(void) {}
++__weak void yellow_led_on(void) {}
++__weak void yellow_led_off(void) {}
++__weak void blue_led_on(void) {}
++__weak void blue_led_off(void) {}
+
+ /*
+ * Why is gd allocated a register? Prior to reloc it might be better to
+diff --git a/include/status_led.h b/include/status_led.h
+index 0eb91b8..b8aaaf7 100644
+--- a/include/status_led.h
++++ b/include/status_led.h
+@@ -272,19 +272,21 @@ extern void __led_set (led_id_t mask, int state);
+ # include <asm/status_led.h>
+ #endif
+
++#endif /* CONFIG_STATUS_LED */
++
+ /*
+ * Coloured LEDs API
+ */
+ #ifndef __ASSEMBLY__
+-extern void coloured_LED_init (void);
+-extern void red_led_on(void);
+-extern void red_led_off(void);
+-extern void green_led_on(void);
+-extern void green_led_off(void);
+-extern void yellow_led_on(void);
+-extern void yellow_led_off(void);
+-extern void blue_led_on(void);
+-extern void blue_led_off(void);
++void coloured_LED_init(void);
++void red_led_on(void);
++void red_led_off(void);
++void green_led_on(void);
++void green_led_off(void);
++void yellow_led_on(void);
++void yellow_led_off(void);
++void blue_led_on(void);
++void blue_led_off(void);
+ #else
+ .extern LED_init
+ .extern red_led_on
+@@ -297,6 +299,4 @@ extern void blue_led_off(void);
+ .extern blue_led_off
+ #endif
+
+-#endif /* CONFIG_STATUS_LED */
+-
+ #endif /* _STATUS_LED_H_ */
+--
+2.5.0
+